From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Maxime Ripard <maxime@cerno.tech>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: kbuild: Pass DT_SCHEMA_FILES to dt-validate
Date: Thu, 10 Mar 2022 09:49:27 -0600 [thread overview]
Message-ID: <YioeB5UgtImMJsMQ@robh.at.kernel.org> (raw)
In-Reply-To: <CAMuHMdXBkLbQVcNYhd=7z0RtU0CicsTF2BQLFRGBX6pNZZVadA@mail.gmail.com>
On Fri, Mar 04, 2022 at 03:49:20PM +0100, Geert Uytterhoeven wrote:
> Hi Rob,
>
> On Fri, Mar 4, 2022 at 3:31 PM Rob Herring <robh@kernel.org> wrote:
> > On Fri, Mar 04, 2022 at 03:05:13PM +0100, Geert Uytterhoeven wrote:
> > > On Fri, Mar 4, 2022 at 2:57 PM Rob Herring <robh@kernel.org> wrote:
> > > > On Fri, Mar 04, 2022 at 10:32:29AM +0100, Geert Uytterhoeven wrote:
> > > > > On Thu, Mar 3, 2022 at 11:43 PM Rob Herring <robh@kernel.org> wrote:
> > > > > > In preparation for supporting validation of DTB files, the full
> > > > > > processed schema will always be needed in order to extract type
> > > > > > information from it. Therefore, the processed schema containing only
> > > > > > what DT_SCHEMA_FILES specifies won't work. Instead, dt-validate has
> > > > > > gained an option, -l or --limit, to specify which schema(s) to use for
> > > > > > validation.
> > > > > >
> > > > > > As the command line option is new, we the minimum dtschema version must be
> > > > > > updated.
> > > > > >
> > > > > > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > > > > > Signed-off-by: Rob Herring <robh@kernel.org>
>
> > > With this series applied, the various salvator-xs DTS files are now
> > > throwing up:
> > >
> > > sata: size (19) error for type phandle
> > > backlight: size (11) error for type phandle
> >
> > Those come from the code decoding the properties[1]. Unfortunately, I
> > haven't come up with a prettier way to report those with the filename. I
> > may just remove it because if decoding the property fails, we'll get
> > schema errors later on anyways.
> >
> > But I don't see any 'sata' properties in the DTS files and 'backlight'
> > is a node. Are you building with '-@'? I probably need to skip
> > __symbols__ nodes. The overlay side is handled because examples are
> > built as overlays (to allow unresolved phandles).
>
> Yes I am. Dropping the "-@" fixes the issue.
FYI, now fixed in v2022.03.1.
Rob
next prev parent reply other threads:[~2022-03-10 15:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 22:42 [PATCH 0/2] dt-bindings: DTB based validation Rob Herring
2022-03-03 22:42 ` [PATCH 1/2] dt-bindings: kbuild: Pass DT_SCHEMA_FILES to dt-validate Rob Herring
2022-03-04 9:32 ` Geert Uytterhoeven
2022-03-04 13:57 ` Rob Herring
2022-03-04 14:05 ` Geert Uytterhoeven
2022-03-04 14:30 ` Rob Herring
2022-03-04 14:49 ` Geert Uytterhoeven
2022-03-10 15:49 ` Rob Herring [this message]
2022-03-04 11:48 ` Laurent Pinchart
2022-03-04 14:03 ` Rob Herring
2022-03-03 22:42 ` [PATCH 2/2] dt-bindings: kbuild: Use DTB files for validation Rob Herring
2022-03-04 11:55 ` Laurent Pinchart
2022-03-04 14:07 ` Rob Herring
2022-03-07 12:20 ` Geert Uytterhoeven
2022-03-07 17:00 ` Rob Herring
2022-03-08 8:37 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YioeB5UgtImMJsMQ@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=maxime@cerno.tech \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox