From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: patches@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: decompressor: do not copy source files while building
Date: Fri, 11 Mar 2022 12:07:03 +0000 [thread overview]
Message-ID: <Yis7Z90qvPz+EcTk@shell.armlinux.org.uk> (raw)
In-Reply-To: <20211030175258.1716178-1-masahiroy@kernel.org>
On Sun, Oct 31, 2021 at 02:52:58AM +0900, Masahiro Yamada wrote:
> As commit 7ae4a78daacf ("ARM: 8969/1: decompressor: simplify libfdt
> builds") stated, copying source files during the build time may not
> end up with as clean code as expected.
>
> Do similar for the other library files for further cleanups of the
> Makefile and .gitignore.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Hi,
I am now seeing the following every time I run a build:
GEN Makefile
CALL .../linux-rmk/scripts/atomic/check-atomics.sh
CALL .../linux-rmk/scripts/checksyscalls.sh
CHK include/generated/compile.h
Kernel: arch/arm/boot/Image is ready
AS arch/arm/boot/compressed/lib1funcs.o
AS arch/arm/boot/compressed/ashldi3.o
AS arch/arm/boot/compressed/bswapsdi2.o
LD arch/arm/boot/compressed/vmlinux
OBJCOPY arch/arm/boot/zImage
Kernel: arch/arm/boot/zImage is ready
In other words, those three objects are always rebuilt even though
they haven't changed.
I've tried removing the arch/arm/boot/compressed directory in the
build tree, but that doesn't make any difference.
Running with V=2 shows:
AS arch/arm/boot/compressed/lib1funcs.o - due to lib1funcs.o not in $(tar
gets)
AS arch/arm/boot/compressed/ashldi3.o - due to ashldi3.o not in $(targets)
AS arch/arm/boot/compressed/bswapsdi2.o - due to bswapsdi2.o not in $(targets)
It looks to me like:
OBJS += lib1funcs.o ashldi3.o bswapsdi2.o
in your patch should have been added before:
targets := vmlinux vmlinux.lds piggy_data piggy.o \
head.o $(OBJS)
Please confirm.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-03-11 12:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 17:52 [PATCH] ARM: decompressor: do not copy source files while building Masahiro Yamada
2022-03-11 12:07 ` Russell King (Oracle) [this message]
2022-03-13 16:35 ` Masahiro Yamada
2022-03-25 2:54 ` Masahiro Yamada
2022-03-30 16:22 ` Russell King (Oracle)
2022-03-31 9:19 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yis7Z90qvPz+EcTk@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=patches@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox