Re: [PATCH v3 07/10] dt-bindings: arm: Add HPE GXP Binding

Krzysztof Kozlowski
2022-03-11T10:20:15Z

On 10/03/2022 20:52, nick.hawkins@hpe.com wrote:
> From: Nick Hawkins <nick.hawkins@hpe.com>
>
> This adds support for the hpe,gxp binding. The GXP is based on
> the cortex a9 processor and supports arm7.
>
> Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>
> ---
> .../devicetree/bindings/arm/gxp.yaml | 53 +++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/gxp.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/gxp.yaml b/Documentation/devicetree/bindings/arm/gxp.yaml
> new file mode 100644
> index 000000000000..edfd331c493e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/gxp.yaml

Missing vendor prefix in file name, so "hpe,gxp.yaml"

> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/gxp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HPE bmc GXP SoC driver

Driver does not fit here. I think you are adding HPE GXP platforms? If yes

> +
> +maintainers:
> + - Nick Hawkins <nick.hawkins@hpe.com>
> + - Jean-Marie Verdun <verdun@hpe.com>
> +
> +properties:
> + compatible:
> + const: hpe,gxp

This is not proper SoC/boards description. Look at intel,keembay.yaml
for example.

You also miss here other compatibles - for board(s).

> +
> + "#address-cells":
> + const: 1
> +
> +required:
> + - compatible
> +
> +additionalProperties: true
> +
> +examples:
> + - |

Skip the example, platform bindings do not have them.

Best regards,
Krzysztof