From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tanjore Suresh <tansuresh@google.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH 1/3] driver core: Support asynchronous driver shutdown
Date: Fri, 25 Mar 2022 06:59:25 +0100 [thread overview]
Message-ID: <Yj1aPdSjmTMAhTCo@kroah.com> (raw)
In-Reply-To: <20220324213445.3055538-1-tansuresh@google.com>
On Thu, Mar 24, 2022 at 02:34:45PM -0700, Tanjore Suresh wrote:
> --- a/include/linux/device/bus.h
> +++ b/include/linux/device/bus.h
> @@ -49,6 +49,14 @@ struct fwnode_handle;
> * will never get called until they do.
> * @remove: Called when a device removed from this bus.
> * @shutdown: Called at shut-down time to quiesce the device.
> + * @shutdown_pre: Called at the shutdown-time to start the shutdown
> + * process on the device. This entry point will be called
> + * only when the bus driver has indicated it would like
> + * to participate in asynchronous shutdown completion.
> + * @shutdown_post: Called at shutdown-time to complete the shutdown
> + * process of the device. This entry point will be called
> + * only when the bus drive has indicated it would like to
> + * participate in the asynchronous shutdown completion.
Sorry, but no, this should not be needed expecially as you did not offer
any justification or reason to do so.
Nor did you send the remaining changes in the series to me, and why
would these be "trivial"?
Please work with others at Google who know how to submit changes to the
kernel first and get their review and signed-off-by on the changes
before sending them out again.
good luck!
greg k-h
next prev parent reply other threads:[~2022-03-25 5:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 21:34 [PATCH 1/3] driver core: Support asynchronous driver shutdown Tanjore Suresh
2022-03-25 5:59 ` Greg Kroah-Hartman [this message]
2022-03-25 13:24 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yj1aPdSjmTMAhTCo@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tansuresh@google.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox