Re: [PATCH v4 1/4] tools: arm64: Import cputype.h

Ali Saidi
2022-03-25T19:24:51Z

Hi Arnaldo,

On Fri, 25 Mar 2022 18:39:44 -0000, Arnaldo Carvalho de Melo wrote:
> Em Thu, Mar 24, 2022 at 06:33:20PM +0000, Ali Saidi escreveu:
> > Bring-in the kernel's arch/arm64/include/asm/cputype.h into tools/
> > for arm64 to make use of all the core-type definitions in perf.
> >
> > Replace sysreg.h with the version already imported into tools/.
>
> You forgot to add it to tools/perf/check-headers.sh so that we get
> notificed when the original file in the kernel sources gets updated, so
> that we can check if this needs any tooling adjustments.

Sorry.

> ⬢[acme@toolbox perf]$ diff -u tools/arch/arm64/include/asm/cputype.h arch/arm64/include/asm/cputype.h
> --- tools/arch/arm64/include/asm/cputype.h 2022-03-25 15:29:41.185173403 -0300
> +++ arch/arm64/include/asm/cputype.h 2022-03-22 17:52:10.881311839 -0300
> @@ -170,7 +170,7 @@
>
> #ifndef __ASSEMBLY__
>
> -#include "sysreg.h"
> +#include <asm/sysreg.h>
>
> #define read_cpuid(reg) read_sysreg_s(SYS_ ## reg)
>
> ⬢[acme@toolbox perf]$
>
>
> I'll add the entry together with the waiver for this specific
> difference.

Thank you!

It looks like it's been missed several times:
% find tools/arch/arm64 -type f
tools/arch/arm64/include/uapi/asm/unistd.h
tools/arch/arm64/include/uapi/asm/bpf_perf_event.h
tools/arch/arm64/include/uapi/asm/kvm.h
tools/arch/arm64/include/uapi/asm/mman.h
tools/arch/arm64/include/uapi/asm/perf_regs.h
tools/arch/arm64/include/uapi/asm/bitsperlong.h
tools/arch/arm64/include/asm/barrier.h
tools/arch/arm64/include/asm/cputype.h
tools/arch/arm64/include/asm/sysreg.h

% grep arm64 tools/perf/check-headers.sh
arch/arm64/include/uapi/asm/perf_regs.h
arch/arm64/include/uapi/asm/kvm.h
arch/arm64/include/uapi/asm/unistd.h

Thanks,
Ali