public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Aleksa Savic <savicaleksa83@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: (aquacomputer_d5next) Add support for Aquacomputer Octo
Date: Sat, 26 Mar 2022 15:51:55 +0100	[thread overview]
Message-ID: <Yj8oi/2gvMb0nsgQ@fedora> (raw)
In-Reply-To: <083c2e34-dd56-07b1-543f-1627bd77acf2@roeck-us.net>

Hi Guenter,

Thanks the for the review. The missing break; statements are my
oversight, I'd never omit them otherwise. Will fix in v3.

Yes, those should be centi-percent if I'm not mistaken... For
example, 47.52% is read as 4752 from the device, so that's
divided by 100 and scaled to PWM.

Aleksa

      reply	other threads:[~2022-03-26 14:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-26 10:12 [PATCH v2] hwmon: (aquacomputer_d5next) Add support for Aquacomputer Octo Aleksa Savic
2022-03-26 12:36 ` kernel test robot
2022-03-26 12:56   ` Aleksa Savic
2022-03-26 13:01 ` Guenter Roeck
2022-03-26 14:51   ` Aleksa Savic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yj8oi/2gvMb0nsgQ@fedora \
    --to=savicaleksa83@gmail.com \
    --cc=corbet@lwn.net \
    --cc=jdelvare@suse.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox