Re: [PATCH v2 3/4] arm64: dts: qcom: sm8150: Add pdc interrupt controller node

Bjorn Andersson
2022-03-24T12:24:20Z

On Wed 16 Mar 22:51 PDT 2022, Bhupesh Sharma wrote:

> Hi Bjorn,
>
> Thanks for your review.
>
> On Tue, 15 Mar 2022 at 21:48, Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
> >
> > On Sat 26 Feb 12:40 CST 2022, Bhupesh Sharma wrote:
> >
> > > Add pdc interrupt controller for sm8150.
> > >
> > > Cc: Maulik Shah <quic_mkshah@quicinc.com>
> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > > Cc: Vinod Koul <vkoul@kernel.org>
> > > Cc: Rob Herring <robh@kernel.org>
> > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> > > ---
> > > arch/arm64/boot/dts/qcom/sm8150.dtsi | 10 ++++++++++
> > > 1 file changed, 10 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > > index 6012322a5984..aaeacd379460 100644
> > > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > > @@ -1626,6 +1626,16 @@ system-cache-controller@9200000 {
> > > interrupts = <GIC_SPI 582 IRQ_TYPE_LEVEL_HIGH>;
> > > };
> > >
> > > + pdc: interrupt-controller@b220000 {
> > > + compatible = "qcom,sm8150-pdc", "qcom,pdc";
> > > + reg = <0 0x0b220000 0 0x400>;
> > > + qcom,pdc-ranges = <0 480 94>, <94 609 31>,
> > > + <125 63 1>;
> >
> > When I look at the platform documentation I get the impression that this
> > should be: <0 480 94>, <94 609 32>;
> >
> > Can you confirm that the last signal is correctly described?
>
> Yes, I confirmed by double checking the entries in downstream 'pdc-sm8150.c'.
> The pdc pins in the 2nd range start from 94 and end at 124, so a total
> of 31 entries, but both 94 and 124 pins included.
>
> Or, am I missing something?
>

Thanks for double checking, let's follow the downstream kernel.
I will merge the patch as you proposed it.

Thanks,
Bjorn

> Thanks,
> Bhupesh
>
> > > + #interrupt-cells = <2>;
> > > + interrupt-parent = <&intc>;
> > > + interrupt-controller;
> > > + };
> > > +
> > > ufs_mem_hc: ufshc@1d84000 {
> > > compatible = "qcom,sm8150-ufshc", "qcom,ufshc",
> > > "jedec,ufs-2.0";
> > > --
> > > 2.35.1
> > >