From: Christoph Hellwig <hch@infradead.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Joerg Roedel <joro@8bytes.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Will Deacon <will@kernel.org>,
Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
"open list:AMD IOMMU (AMD-VI)" <iommu@lists.linux-foundation.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:THUNDERBOLT DRIVER" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 2/2] thunderbolt: Use pre-boot DMA protection on AMD systems
Date: Tue, 15 Mar 2022 09:48:17 -0700 [thread overview]
Message-ID: <YjDDUUeZ/dvUZoDN@infradead.org> (raw)
In-Reply-To: <20220315162455.5190-2-mario.limonciello@amd.com>
On Tue, Mar 15, 2022 at 11:24:55AM -0500, Mario Limonciello wrote:
> - * handled natively using IOMMU. It is enabled when IOMMU is
> - * enabled and ACPI DMAR table has DMAR_PLATFORM_OPT_IN set.
> + * handled natively using IOMMU. It is enabled when the IOMMU is
> + * enabled and either:
> + * ACPI DMAR table has DMAR_PLATFORM_OPT_IN set
> + * or
> + * ACPI IVRS table has DMA_REMAP bitset
> */
> return sprintf(buf, "%d\n",
> - iommu_present(&pci_bus_type) && dmar_platform_optin());
> + iommu_present(&pci_bus_type) &&
> + (dmar_platform_optin() || amd_ivrs_remap_support()));
Yikes. No, the thunderbot code does not have any business poking into
either dmar_platform_optin or amd_ivrs_remap_support. This needs
a proper abstration from the IOMMU code.
next prev parent reply other threads:[~2022-03-15 16:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 16:24 [PATCH 1/2] iommu/amd: Add support to indicate whether DMA remap support is enabled Mario Limonciello
2022-03-15 16:24 ` [PATCH 2/2] thunderbolt: Use pre-boot DMA protection on AMD systems Mario Limonciello
2022-03-15 16:48 ` Christoph Hellwig [this message]
2022-03-15 16:54 ` Limonciello, Mario
2022-03-15 18:07 ` Robin Murphy
2022-03-15 18:36 ` Limonciello, Mario
2022-03-15 21:34 ` Limonciello, Mario
2022-03-15 22:04 ` Robin Murphy
2022-03-16 9:50 ` Mika Westerberg
2022-03-16 1:32 ` kernel test robot
2022-03-16 0:51 ` [PATCH 1/2] iommu/amd: Add support to indicate whether DMA remap support is enabled kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjDDUUeZ/dvUZoDN@infradead.org \
--to=hch@infradead.org \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox