From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3BE5C433EF for ; Tue, 15 Mar 2022 17:41:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350626AbiCORmc (ORCPT ); Tue, 15 Mar 2022 13:42:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236628AbiCORmb (ORCPT ); Tue, 15 Mar 2022 13:42:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2339A58E4F; Tue, 15 Mar 2022 10:41:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7C9A6615AF; Tue, 15 Mar 2022 17:41:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C2B7C340E8; Tue, 15 Mar 2022 17:41:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647366077; bh=EmukrZJTdPmX8L6VDOzfmJxS+zks3StStKzljU+KjtE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vieN7aSfas4bwleZQHaaKc295kUVhZzTXvlvwVkk4vzdb7Wgna7FFSScJko73nmLs 8AvMlkMjJuD+XC6wp6kbCMKA5XWcYPdqvQp3rI6nRLi7VBwkLIpauQ06Nik/oDH9ol XP+Ps48LyJwWQ7Kz6051771iMJwhU/gqzkoze/Qk= Date: Tue, 15 Mar 2022 18:41:09 +0100 From: Greg Kroah-Hartman To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen/usb: harden xen_hcd against malicious backends Message-ID: References: <20220311103509.12908-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220311103509.12908-1-jgross@suse.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 11, 2022 at 11:35:09AM +0100, Juergen Gross wrote: > Make sure a malicious backend can't cause any harm other than wrong > I/O data. > > Missing are verification of the request id in a response, sanitizing > the reported actual I/O length, and protection against interrupt storms > from the backend. > > Signed-off-by: Juergen Gross > --- > drivers/usb/host/xen-hcd.c | 57 ++++++++++++++++++++++++++++---------- > 1 file changed, 43 insertions(+), 14 deletions(-) Fails to apply to my tree: checking file drivers/usb/host/xen-hcd.c Hunk #2 succeeded at 720 (offset -1 lines). Hunk #3 succeeded at 807 (offset -3 lines). Hunk #4 succeeded at 934 (offset -5 lines). Hunk #5 FAILED at 986. Hunk #6 succeeded at 1003 with fuzz 1 (offset -10 lines). Hunk #7 succeeded at 1048 (offset -10 lines). Hunk #8 succeeded at 1072 (offset -10 lines). Hunk #9 succeeded at 1161 (offset -10 lines). Hunk #10 succeeded at 1516 (offset -10 lines). 1 out of 10 hunks FAILED Any hints? thanks, greg k-h