From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 41BBAC433F5
	for <linux-kernel@archiver.kernel.org>; Wed, 16 Mar 2022 06:40:07 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1346540AbiCPGlQ (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 16 Mar 2022 02:41:16 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41306 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231577AbiCPGlO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Mar 2022 02:41:14 -0400
Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D12635B3C5
        for <linux-kernel@vger.kernel.org>; Tue, 15 Mar 2022 23:40:00 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id 95C05B81894
        for <linux-kernel@vger.kernel.org>; Wed, 16 Mar 2022 06:39:59 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1C0FC340E9;
        Wed, 16 Mar 2022 06:39:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1647412798;
        bh=ZCM0KWZVm8GiuvHcY7t2+wvpzLhzc2pm5OpcsTiB7tw=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=hwmsPY2OLxoHiSqxSHlksEZt/syviCaFroQOXVytYD5WNTClOPfjRzdenxVF7WWww
         u4oMfReliVtkWAJgOIpI8IALcjEVdYCO6lSiQnqebY7+OwcIIDliMNqs132ogINKRM
         i7Yp4x1AI4bGfVnapgGw1PfKwSm78VA6igJgx7SU=
Date:   Wed, 16 Mar 2022 07:39:49 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Martin Kaiser <lists@kaiser.cx>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        Michael Straube <straube.linux@gmail.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] staging: r8188eu: some rx cleanups
Message-ID: <YjGGNf5Pv7jp6MAv@kroah.com>
References: <20220305185351.1409232-1-martin@kaiser.cx>
 <Yi97s4Eu20CVE/Ds@kroah.com>
 <20220315205528.vfby3delkhyidbv5@viti.kaiser.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220315205528.vfby3delkhyidbv5@viti.kaiser.cx>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 15, 2022 at 09:55:28PM +0100, Martin Kaiser wrote:
> Thus wrote Greg Kroah-Hartman (gregkh@linuxfoundation.org):
> 
> > On Sat, Mar 05, 2022 at 07:53:45PM +0100, Martin Kaiser wrote:
> > > Here's another set with simple cleanups in the code for receiving frames.
> 
> > > Martin Kaiser (6):
> > >   staging: r8188eu: remove unnecessary initializations
> > >   staging: r8188eu: remove three unused receive defines
> > >   staging: r8188eu: remove unused function prototype
> > >   staging: r8188eu: make rtl8188e_process_phy_info static
> > >   staging: r8188eu: remove some unused local ieee80211 macros
> > >   staging: r8188eu: remove local BIT macro
> 
> > >  drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c |  6 +---
> > >  .../staging/r8188eu/include/rtl8188e_recv.h   |  6 ----
> > >  drivers/staging/r8188eu/include/wifi.h        | 34 +------------------
> > >  3 files changed, 2 insertions(+), 44 deletions(-)
> 
> > > -- 
> > > 2.30.2
> 
> 
> 
> > This series breaks the build:
> 
> on x86_64 - and I tested only on arm32 :-(
> 
> > drivers/staging/r8188eu/core/rtw_wlan_util.c: In function ‘update_IOT_info’:
> > drivers/staging/r8188eu/core/rtw_wlan_util.c:1279:42: error: conversion from ‘long unsigned int’ to ‘u32’ {aka ‘unsigned int’} changes value from ‘18446744073709551611’ to ‘4294967291’ [-Werror=overflow]
> >  1279 |                 Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false);
> >       |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/staging/r8188eu/core/rtw_wlan_util.c:1285:42: error: conversion from ‘long unsigned int’ to ‘u32’ {aka ‘unsigned int’} changes value from ‘18446744073709551611’ to ‘4294967291’ [-Werror=overflow]
> >  1285 |                 Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false);
> >       |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> 
> > I'm going to drop it from my queue now.
> 
> The driver's BIT(x) macro was 1 << (x), the "global" one uses 1UL << (x).
> DYNAMIC_BB_DYNAMIC_TXPWR needs a cast to u32. I've just sent v2.

There shouldn't need to be a cast when using the BIT macro, so be
careful...