* [PATCH] staging: sm750fb: fix CamelCase naming style
@ 2022-03-16 11:32 Nam Cao
2022-03-16 14:06 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Nam Cao @ 2022-03-16 11:32 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh, linux-staging, linux-kernel; +Cc: Nam Cao
Fix CamelCase names defined in ddk750_dvi.c and ddk750_dvi.h, as
reported by checkpatch.pl.
Signed-off-by: Nam Cao <cvn249@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 50 +++++++++++-----------
drivers/staging/sm750fb/ddk750_dvi.h | 64 ++++++++++++++--------------
2 files changed, 57 insertions(+), 57 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index cd564ea40779..48f40dcc5ffd 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -11,41 +11,41 @@
* function API. Please set the function pointer to NULL whenever the function
* is not supported.
*/
-static struct dvi_ctrl_device g_dcftSupportedDviController[] = {
+static struct dvi_ctrl_device g_dcft_supported_dvi_controller[] = {
#ifdef DVI_CTRL_SII164
{
- .pfnInit = sii164InitChip,
- .pfnGetVendorId = sii164GetVendorID,
- .pfnGetDeviceId = sii164GetDeviceID,
+ .pfn_init = sii164InitChip,
+ .pfn_get_vendor_id = sii164GetVendorID,
+ .pfn_get_device_id = sii164GetDeviceID,
#ifdef SII164_FULL_FUNCTIONS
- .pfnResetChip = sii164ResetChip,
- .pfnGetChipString = sii164GetChipString,
- .pfnSetPower = sii164SetPower,
- .pfnEnableHotPlugDetection = sii164EnableHotPlugDetection,
- .pfnIsConnected = sii164IsConnected,
- .pfnCheckInterrupt = sii164CheckInterrupt,
- .pfnClearInterrupt = sii164ClearInterrupt,
+ .pfn_reset_chip = sii164ResetChip,
+ .pfn_get_chip_string = sii164GetChipString,
+ .pfn_set_power = sii164SetPower,
+ .pfn_enable_hot_plug_detection = sii164EnableHotPlugDetection,
+ .pfn_is_connected = sii164IsConnected,
+ .pfn_check_interrupt = sii164CheckInterrupt,
+ .pfn_clear_interrupt = sii164ClearInterrupt,
#endif
},
#endif
};
-int dviInit(unsigned char edge_select,
- unsigned char bus_select,
- unsigned char dual_edge_clk_select,
- unsigned char hsync_enable,
- unsigned char vsync_enable,
- unsigned char deskew_enable,
- unsigned char deskew_setting,
- unsigned char continuous_sync_enable,
- unsigned char pll_filter_enable,
- unsigned char pll_filter_value)
+int dvi_init(unsigned char edge_select,
+ unsigned char bus_select,
+ unsigned char dual_edge_clk_select,
+ unsigned char hsync_enable,
+ unsigned char vsync_enable,
+ unsigned char deskew_enable,
+ unsigned char deskew_setting,
+ unsigned char continuous_sync_enable,
+ unsigned char pll_filter_enable,
+ unsigned char pll_filter_value)
{
- struct dvi_ctrl_device *pCurrentDviCtrl;
+ struct dvi_ctrl_device *p_current_dvi_ctrl;
- pCurrentDviCtrl = g_dcftSupportedDviController;
- if (pCurrentDviCtrl->pfnInit) {
- return pCurrentDviCtrl->pfnInit(edge_select,
+ p_current_dvi_ctrl = g_dcft_supported_dvi_controller;
+ if (p_current_dvi_ctrl->pfn_init) {
+ return p_current_dvi_ctrl->pfn_init(edge_select,
bus_select,
dual_edge_clk_select,
hsync_enable,
diff --git a/drivers/staging/sm750fb/ddk750_dvi.h b/drivers/staging/sm750fb/ddk750_dvi.h
index 1c7a565b617a..ab00f8621375 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.h
+++ b/drivers/staging/sm750fb/ddk750_dvi.h
@@ -4,54 +4,54 @@
/* dvi chip stuffs structros */
-typedef long (*PFN_DVICTRL_INIT)(unsigned char edgeSelect,
- unsigned char busSelect,
- unsigned char dualEdgeClkSelect,
- unsigned char hsyncEnable,
- unsigned char vsyncEnable,
- unsigned char deskewEnable,
- unsigned char deskewSetting,
- unsigned char continuousSyncEnable,
- unsigned char pllFilterEnable,
- unsigned char pllFilterValue);
+typedef long (*PFN_DVICTRL_INIT)(unsigned char edge_select,
+ unsigned char bus_select,
+ unsigned char dual_edge_clk_select,
+ unsigned char hsync_enable,
+ unsigned char vsync_enable,
+ unsigned char deskew_enable,
+ unsigned char deskew_eetting,
+ unsigned char continuous_sync_enable,
+ unsigned char pll_filter_enable,
+ unsigned char pll_filter_value);
typedef void (*PFN_DVICTRL_RESETCHIP)(void);
typedef char* (*PFN_DVICTRL_GETCHIPSTRING)(void);
typedef unsigned short (*PFN_DVICTRL_GETVENDORID)(void);
typedef unsigned short (*PFN_DVICTRL_GETDEVICEID)(void);
-typedef void (*PFN_DVICTRL_SETPOWER)(unsigned char powerUp);
-typedef void (*PFN_DVICTRL_HOTPLUGDETECTION)(unsigned char enableHotPlug);
+typedef void (*PFN_DVICTRL_SETPOWER)(unsigned char power_up);
+typedef void (*PFN_DVICTRL_HOTPLUGDETECTION)(unsigned char enable_hot_plug);
typedef unsigned char (*PFN_DVICTRL_ISCONNECTED)(void);
typedef unsigned char (*PFN_DVICTRL_CHECKINTERRUPT)(void);
typedef void (*PFN_DVICTRL_CLEARINTERRUPT)(void);
/* Structure to hold all the function pointer to the DVI Controller. */
struct dvi_ctrl_device {
- PFN_DVICTRL_INIT pfnInit;
- PFN_DVICTRL_RESETCHIP pfnResetChip;
- PFN_DVICTRL_GETCHIPSTRING pfnGetChipString;
- PFN_DVICTRL_GETVENDORID pfnGetVendorId;
- PFN_DVICTRL_GETDEVICEID pfnGetDeviceId;
- PFN_DVICTRL_SETPOWER pfnSetPower;
- PFN_DVICTRL_HOTPLUGDETECTION pfnEnableHotPlugDetection;
- PFN_DVICTRL_ISCONNECTED pfnIsConnected;
- PFN_DVICTRL_CHECKINTERRUPT pfnCheckInterrupt;
- PFN_DVICTRL_CLEARINTERRUPT pfnClearInterrupt;
+ PFN_DVICTRL_INIT pfn_init;
+ PFN_DVICTRL_RESETCHIP pfn_reset_chip;
+ PFN_DVICTRL_GETCHIPSTRING pfn_get_chip_string;
+ PFN_DVICTRL_GETVENDORID pfn_get_vendor_id;
+ PFN_DVICTRL_GETDEVICEID pfn_get_device_id;
+ PFN_DVICTRL_SETPOWER pfn_set_power;
+ PFN_DVICTRL_HOTPLUGDETECTION pfn_enable_hot_plug_detection;
+ PFN_DVICTRL_ISCONNECTED pfn_is_connected;
+ PFN_DVICTRL_CHECKINTERRUPT pfn_check_interrupt;
+ PFN_DVICTRL_CLEARINTERRUPT pfn_clear_interrupt;
};
#define DVI_CTRL_SII164
/* dvi functions prototype */
-int dviInit(unsigned char edgeSelect,
- unsigned char busSelect,
- unsigned char dualEdgeClkSelect,
- unsigned char hsyncEnable,
- unsigned char vsyncEnable,
- unsigned char deskewEnable,
- unsigned char deskewSetting,
- unsigned char continuousSyncEnable,
- unsigned char pllFilterEnable,
- unsigned char pllFilterValue);
+int dvi_init(unsigned char edge_select,
+ unsigned char bus_select,
+ unsigned char dual_edge_clk_select,
+ unsigned char hsync_enable,
+ unsigned char vsync_enable,
+ unsigned char deskew_enable,
+ unsigned char deskew_setting,
+ unsigned char continuous_sync_enable,
+ unsigned char pll_filter_enable,
+ unsigned char pll_filter_value);
#endif
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: sm750fb: fix CamelCase naming style
2022-03-16 11:32 [PATCH] staging: sm750fb: fix CamelCase naming style Nam Cao
@ 2022-03-16 14:06 ` Greg KH
2022-03-16 20:23 ` Nam Cao
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2022-03-16 14:06 UTC (permalink / raw)
To: Nam Cao; +Cc: sudipm.mukherjee, teddy.wang, linux-staging, linux-kernel
On Wed, Mar 16, 2022 at 11:32:28AM +0000, Nam Cao wrote:
> Fix CamelCase names defined in ddk750_dvi.c and ddk750_dvi.h, as
> reported by checkpatch.pl.
>
> Signed-off-by: Nam Cao <cvn249@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_dvi.c | 50 +++++++++++-----------
> drivers/staging/sm750fb/ddk750_dvi.h | 64 ++++++++++++++--------------
> 2 files changed, 57 insertions(+), 57 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index cd564ea40779..48f40dcc5ffd 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -11,41 +11,41 @@
> * function API. Please set the function pointer to NULL whenever the function
> * is not supported.
> */
> -static struct dvi_ctrl_device g_dcftSupportedDviController[] = {
> +static struct dvi_ctrl_device g_dcft_supported_dvi_controller[] = {
> #ifdef DVI_CTRL_SII164
> {
> - .pfnInit = sii164InitChip,
> - .pfnGetVendorId = sii164GetVendorID,
> - .pfnGetDeviceId = sii164GetDeviceID,
> + .pfn_init = sii164InitChip,
> + .pfn_get_vendor_id = sii164GetVendorID,
> + .pfn_get_device_id = sii164GetDeviceID,
> #ifdef SII164_FULL_FUNCTIONS
> - .pfnResetChip = sii164ResetChip,
> - .pfnGetChipString = sii164GetChipString,
> - .pfnSetPower = sii164SetPower,
> - .pfnEnableHotPlugDetection = sii164EnableHotPlugDetection,
> - .pfnIsConnected = sii164IsConnected,
> - .pfnCheckInterrupt = sii164CheckInterrupt,
> - .pfnClearInterrupt = sii164ClearInterrupt,
> + .pfn_reset_chip = sii164ResetChip,
> + .pfn_get_chip_string = sii164GetChipString,
> + .pfn_set_power = sii164SetPower,
> + .pfn_enable_hot_plug_detection = sii164EnableHotPlugDetection,
> + .pfn_is_connected = sii164IsConnected,
> + .pfn_check_interrupt = sii164CheckInterrupt,
> + .pfn_clear_interrupt = sii164ClearInterrupt,
> #endif
> },
> #endif
> };
>
> -int dviInit(unsigned char edge_select,
> - unsigned char bus_select,
> - unsigned char dual_edge_clk_select,
> - unsigned char hsync_enable,
> - unsigned char vsync_enable,
> - unsigned char deskew_enable,
> - unsigned char deskew_setting,
> - unsigned char continuous_sync_enable,
> - unsigned char pll_filter_enable,
> - unsigned char pll_filter_value)
> +int dvi_init(unsigned char edge_select,
> + unsigned char bus_select,
> + unsigned char dual_edge_clk_select,
> + unsigned char hsync_enable,
> + unsigned char vsync_enable,
> + unsigned char deskew_enable,
> + unsigned char deskew_setting,
> + unsigned char continuous_sync_enable,
> + unsigned char pll_filter_enable,
> + unsigned char pll_filter_value)
> {
> - struct dvi_ctrl_device *pCurrentDviCtrl;
> + struct dvi_ctrl_device *p_current_dvi_ctrl;
>
> - pCurrentDviCtrl = g_dcftSupportedDviController;
> - if (pCurrentDviCtrl->pfnInit) {
> - return pCurrentDviCtrl->pfnInit(edge_select,
> + p_current_dvi_ctrl = g_dcft_supported_dvi_controller;
> + if (p_current_dvi_ctrl->pfn_init) {
> + return p_current_dvi_ctrl->pfn_init(edge_select,
> bus_select,
> dual_edge_clk_select,
> hsync_enable,
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.h b/drivers/staging/sm750fb/ddk750_dvi.h
> index 1c7a565b617a..ab00f8621375 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.h
> +++ b/drivers/staging/sm750fb/ddk750_dvi.h
> @@ -4,54 +4,54 @@
>
> /* dvi chip stuffs structros */
>
> -typedef long (*PFN_DVICTRL_INIT)(unsigned char edgeSelect,
> - unsigned char busSelect,
> - unsigned char dualEdgeClkSelect,
> - unsigned char hsyncEnable,
> - unsigned char vsyncEnable,
> - unsigned char deskewEnable,
> - unsigned char deskewSetting,
> - unsigned char continuousSyncEnable,
> - unsigned char pllFilterEnable,
> - unsigned char pllFilterValue);
> +typedef long (*PFN_DVICTRL_INIT)(unsigned char edge_select,
> + unsigned char bus_select,
> + unsigned char dual_edge_clk_select,
> + unsigned char hsync_enable,
> + unsigned char vsync_enable,
> + unsigned char deskew_enable,
> + unsigned char deskew_eetting,
> + unsigned char continuous_sync_enable,
> + unsigned char pll_filter_enable,
> + unsigned char pll_filter_value);
>
> typedef void (*PFN_DVICTRL_RESETCHIP)(void);
> typedef char* (*PFN_DVICTRL_GETCHIPSTRING)(void);
> typedef unsigned short (*PFN_DVICTRL_GETVENDORID)(void);
> typedef unsigned short (*PFN_DVICTRL_GETDEVICEID)(void);
> -typedef void (*PFN_DVICTRL_SETPOWER)(unsigned char powerUp);
> -typedef void (*PFN_DVICTRL_HOTPLUGDETECTION)(unsigned char enableHotPlug);
> +typedef void (*PFN_DVICTRL_SETPOWER)(unsigned char power_up);
> +typedef void (*PFN_DVICTRL_HOTPLUGDETECTION)(unsigned char enable_hot_plug);
> typedef unsigned char (*PFN_DVICTRL_ISCONNECTED)(void);
> typedef unsigned char (*PFN_DVICTRL_CHECKINTERRUPT)(void);
> typedef void (*PFN_DVICTRL_CLEARINTERRUPT)(void);
>
> /* Structure to hold all the function pointer to the DVI Controller. */
> struct dvi_ctrl_device {
> - PFN_DVICTRL_INIT pfnInit;
> - PFN_DVICTRL_RESETCHIP pfnResetChip;
> - PFN_DVICTRL_GETCHIPSTRING pfnGetChipString;
> - PFN_DVICTRL_GETVENDORID pfnGetVendorId;
> - PFN_DVICTRL_GETDEVICEID pfnGetDeviceId;
> - PFN_DVICTRL_SETPOWER pfnSetPower;
> - PFN_DVICTRL_HOTPLUGDETECTION pfnEnableHotPlugDetection;
> - PFN_DVICTRL_ISCONNECTED pfnIsConnected;
> - PFN_DVICTRL_CHECKINTERRUPT pfnCheckInterrupt;
> - PFN_DVICTRL_CLEARINTERRUPT pfnClearInterrupt;
> + PFN_DVICTRL_INIT pfn_init;
> + PFN_DVICTRL_RESETCHIP pfn_reset_chip;
> + PFN_DVICTRL_GETCHIPSTRING pfn_get_chip_string;
> + PFN_DVICTRL_GETVENDORID pfn_get_vendor_id;
> + PFN_DVICTRL_GETDEVICEID pfn_get_device_id;
> + PFN_DVICTRL_SETPOWER pfn_set_power;
> + PFN_DVICTRL_HOTPLUGDETECTION pfn_enable_hot_plug_detection;
> + PFN_DVICTRL_ISCONNECTED pfn_is_connected;
> + PFN_DVICTRL_CHECKINTERRUPT pfn_check_interrupt;
> + PFN_DVICTRL_CLEARINTERRUPT pfn_clear_interrupt;
Why are you keeping "pfn_"? You do not need to say that this is a
"pointer to a function" anymore, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: sm750fb: fix CamelCase naming style
2022-03-16 14:06 ` Greg KH
@ 2022-03-16 20:23 ` Nam Cao
2022-03-16 22:49 ` [PATCH v2] staging: sm750fb: fix " Nam Cao
0 siblings, 1 reply; 4+ messages in thread
From: Nam Cao @ 2022-03-16 20:23 UTC (permalink / raw)
To: Greg KH; +Cc: sudipm.mukherjee, teddy.wang, linux-staging, linux-kernel
On Wed, Mar 16, 2022 at 03:06:08PM +0100, Greg KH wrote:
> Why are you keeping "pfn_"? You do not need to say that this is a
> "pointer to a function" anymore, right?
>
> thanks,
>
> greg k-h
Thanks for the feedback. As newcomer, I really appreciate it.
I will send updated patch soon.
Best regards,
Nam
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] staging: sm750fb: fix naming style
2022-03-16 20:23 ` Nam Cao
@ 2022-03-16 22:49 ` Nam Cao
0 siblings, 0 replies; 4+ messages in thread
From: Nam Cao @ 2022-03-16 22:49 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh, linux-staging, linux-kernel; +Cc: Nam Cao
Fix CamelCase names defined in ddk750_dvi.c and ddk750_dvi.h, as
reported by checkpatch.pl. Remove name suffixes such as pfn_ and g_.
Signed-off-by: Nam Cao <cvn249@gmail.com>
---
Changes in v2:
- Remove name suffixes including pfn_, g_ and p_.
- Typo: deskew_eetting -> deskew_setting
drivers/staging/sm750fb/ddk750_dvi.c | 68 ++++++++++++++--------------
drivers/staging/sm750fb/ddk750_dvi.h | 64 +++++++++++++-------------
2 files changed, 66 insertions(+), 66 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index cd564ea40779..029d9acec47d 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -11,50 +11,50 @@
* function API. Please set the function pointer to NULL whenever the function
* is not supported.
*/
-static struct dvi_ctrl_device g_dcftSupportedDviController[] = {
+static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
#ifdef DVI_CTRL_SII164
{
- .pfnInit = sii164InitChip,
- .pfnGetVendorId = sii164GetVendorID,
- .pfnGetDeviceId = sii164GetDeviceID,
+ .init = sii164InitChip,
+ .get_vendor_id = sii164GetVendorID,
+ .get_device_id = sii164GetDeviceID,
#ifdef SII164_FULL_FUNCTIONS
- .pfnResetChip = sii164ResetChip,
- .pfnGetChipString = sii164GetChipString,
- .pfnSetPower = sii164SetPower,
- .pfnEnableHotPlugDetection = sii164EnableHotPlugDetection,
- .pfnIsConnected = sii164IsConnected,
- .pfnCheckInterrupt = sii164CheckInterrupt,
- .pfnClearInterrupt = sii164ClearInterrupt,
+ .reset_chip = sii164ResetChip,
+ .get_chip_string = sii164GetChipString,
+ .set_power = sii164SetPower,
+ .enable_hot_plug_detection = sii164EnableHotPlugDetection,
+ .is_connected = sii164IsConnected,
+ .check_interrupt = sii164CheckInterrupt,
+ .clear_interrupt = sii164ClearInterrupt,
#endif
},
#endif
};
-int dviInit(unsigned char edge_select,
- unsigned char bus_select,
- unsigned char dual_edge_clk_select,
- unsigned char hsync_enable,
- unsigned char vsync_enable,
- unsigned char deskew_enable,
- unsigned char deskew_setting,
- unsigned char continuous_sync_enable,
- unsigned char pll_filter_enable,
- unsigned char pll_filter_value)
+int dvi_init(unsigned char edge_select,
+ unsigned char bus_select,
+ unsigned char dual_edge_clk_select,
+ unsigned char hsync_enable,
+ unsigned char vsync_enable,
+ unsigned char deskew_enable,
+ unsigned char deskew_setting,
+ unsigned char continuous_sync_enable,
+ unsigned char pll_filter_enable,
+ unsigned char pll_filter_value)
{
- struct dvi_ctrl_device *pCurrentDviCtrl;
+ struct dvi_ctrl_device *current_dvi_ctrl;
- pCurrentDviCtrl = g_dcftSupportedDviController;
- if (pCurrentDviCtrl->pfnInit) {
- return pCurrentDviCtrl->pfnInit(edge_select,
- bus_select,
- dual_edge_clk_select,
- hsync_enable,
- vsync_enable,
- deskew_enable,
- deskew_setting,
- continuous_sync_enable,
- pll_filter_enable,
- pll_filter_value);
+ current_dvi_ctrl = dcft_supported_dvi_controller;
+ if (current_dvi_ctrl->init) {
+ return current_dvi_ctrl->init(edge_select,
+ bus_select,
+ dual_edge_clk_select,
+ hsync_enable,
+ vsync_enable,
+ deskew_enable,
+ deskew_setting,
+ continuous_sync_enable,
+ pll_filter_enable,
+ pll_filter_value);
}
return -1; /* error */
}
diff --git a/drivers/staging/sm750fb/ddk750_dvi.h b/drivers/staging/sm750fb/ddk750_dvi.h
index 1c7a565b617a..c2518b73bdbd 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.h
+++ b/drivers/staging/sm750fb/ddk750_dvi.h
@@ -4,54 +4,54 @@
/* dvi chip stuffs structros */
-typedef long (*PFN_DVICTRL_INIT)(unsigned char edgeSelect,
- unsigned char busSelect,
- unsigned char dualEdgeClkSelect,
- unsigned char hsyncEnable,
- unsigned char vsyncEnable,
- unsigned char deskewEnable,
- unsigned char deskewSetting,
- unsigned char continuousSyncEnable,
- unsigned char pllFilterEnable,
- unsigned char pllFilterValue);
+typedef long (*PFN_DVICTRL_INIT)(unsigned char edge_select,
+ unsigned char bus_select,
+ unsigned char dual_edge_clk_select,
+ unsigned char hsync_enable,
+ unsigned char vsync_enable,
+ unsigned char deskew_enable,
+ unsigned char deskew_setting,
+ unsigned char continuous_sync_enable,
+ unsigned char pll_filter_enable,
+ unsigned char pll_filter_value);
typedef void (*PFN_DVICTRL_RESETCHIP)(void);
typedef char* (*PFN_DVICTRL_GETCHIPSTRING)(void);
typedef unsigned short (*PFN_DVICTRL_GETVENDORID)(void);
typedef unsigned short (*PFN_DVICTRL_GETDEVICEID)(void);
-typedef void (*PFN_DVICTRL_SETPOWER)(unsigned char powerUp);
-typedef void (*PFN_DVICTRL_HOTPLUGDETECTION)(unsigned char enableHotPlug);
+typedef void (*PFN_DVICTRL_SETPOWER)(unsigned char power_up);
+typedef void (*PFN_DVICTRL_HOTPLUGDETECTION)(unsigned char enable_hot_plug);
typedef unsigned char (*PFN_DVICTRL_ISCONNECTED)(void);
typedef unsigned char (*PFN_DVICTRL_CHECKINTERRUPT)(void);
typedef void (*PFN_DVICTRL_CLEARINTERRUPT)(void);
/* Structure to hold all the function pointer to the DVI Controller. */
struct dvi_ctrl_device {
- PFN_DVICTRL_INIT pfnInit;
- PFN_DVICTRL_RESETCHIP pfnResetChip;
- PFN_DVICTRL_GETCHIPSTRING pfnGetChipString;
- PFN_DVICTRL_GETVENDORID pfnGetVendorId;
- PFN_DVICTRL_GETDEVICEID pfnGetDeviceId;
- PFN_DVICTRL_SETPOWER pfnSetPower;
- PFN_DVICTRL_HOTPLUGDETECTION pfnEnableHotPlugDetection;
- PFN_DVICTRL_ISCONNECTED pfnIsConnected;
- PFN_DVICTRL_CHECKINTERRUPT pfnCheckInterrupt;
- PFN_DVICTRL_CLEARINTERRUPT pfnClearInterrupt;
+ PFN_DVICTRL_INIT init;
+ PFN_DVICTRL_RESETCHIP reset_chip;
+ PFN_DVICTRL_GETCHIPSTRING get_chip_string;
+ PFN_DVICTRL_GETVENDORID get_vendor_id;
+ PFN_DVICTRL_GETDEVICEID get_device_id;
+ PFN_DVICTRL_SETPOWER set_power;
+ PFN_DVICTRL_HOTPLUGDETECTION enable_hot_plug_detection;
+ PFN_DVICTRL_ISCONNECTED is_connected;
+ PFN_DVICTRL_CHECKINTERRUPT check_interrupt;
+ PFN_DVICTRL_CLEARINTERRUPT clear_interrupt;
};
#define DVI_CTRL_SII164
/* dvi functions prototype */
-int dviInit(unsigned char edgeSelect,
- unsigned char busSelect,
- unsigned char dualEdgeClkSelect,
- unsigned char hsyncEnable,
- unsigned char vsyncEnable,
- unsigned char deskewEnable,
- unsigned char deskewSetting,
- unsigned char continuousSyncEnable,
- unsigned char pllFilterEnable,
- unsigned char pllFilterValue);
+int dvi_init(unsigned char edge_select,
+ unsigned char bus_select,
+ unsigned char dual_edge_clk_select,
+ unsigned char hsync_enable,
+ unsigned char vsync_enable,
+ unsigned char deskew_enable,
+ unsigned char deskew_setting,
+ unsigned char continuous_sync_enable,
+ unsigned char pll_filter_enable,
+ unsigned char pll_filter_value);
#endif
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-16 22:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-16 11:32 [PATCH] staging: sm750fb: fix CamelCase naming style Nam Cao
2022-03-16 14:06 ` Greg KH
2022-03-16 20:23 ` Nam Cao
2022-03-16 22:49 ` [PATCH v2] staging: sm750fb: fix " Nam Cao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox