From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: sched_core_balance() releasing interrupts with pi_lock held
Date: Wed, 16 Mar 2022 17:18:40 +0100 [thread overview]
Message-ID: <YjIN4C8EFIOOR+o4@linutronix.de> (raw)
In-Reply-To: <YjIKQBIbJR/kRR+N@linutronix.de>
On 2022-03-16 17:03:14 [+0100], To Steven Rostedt wrote:
…
> which looked right but RT still fall apart:
…
> | =====================================
> | WARNING: bad unlock balance detected!
> | 5.17.0-rc8-rt14+ #10 Not tainted
> | -------------------------------------
…
…
> It is always the local-lock that is breaks apart. Based on "locks held"
> and the lock it tries to release it looks like the lock was acquired on
> CPU-A and released on CPU-B.
with
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 33ce5cd113d8..f4675bd8f878 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5968,6 +5967,9 @@ static bool try_steal_cookie(int this, int that)
if (p == src->core_pick || p == src->curr)
goto next;
+ if (p->migration_disabled)
+ goto next;
+
if (!cpumask_test_cpu(this, &p->cpus_mask))
goto next;
on top my problems are gone. Let me do some testing and then I would
patch unless PeterZ does the yelling :)
> > Thanks,
> >
> > -- Steve
>
Sebastian
next prev parent reply other threads:[~2022-03-16 16:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 21:14 sched_core_balance() releasing interrupts with pi_lock held Steven Rostedt
2022-03-15 21:46 ` Steven Rostedt
2022-03-16 16:03 ` Sebastian Andrzej Siewior
2022-03-16 16:18 ` Sebastian Andrzej Siewior [this message]
2022-03-16 17:05 ` Sebastian Andrzej Siewior
2022-03-16 20:35 ` Peter Zijlstra
2022-03-17 12:09 ` Sebastian Andrzej Siewior
2022-03-17 14:51 ` [PATCH] sched: Teach the forced-newidle balancer about CPU affinity limitation Sebastian Andrzej Siewior
2022-04-05 8:22 ` [tip: sched/urgent] " tip-bot2 for Sebastian Andrzej Siewior
2022-03-16 20:27 ` sched_core_balance() releasing interrupts with pi_lock held Peter Zijlstra
2022-03-16 21:03 ` Peter Zijlstra
2022-03-21 17:30 ` Steven Rostedt
2022-03-29 21:22 ` Steven Rostedt
2022-04-04 20:17 ` T.J. Alumbaugh
2022-04-05 7:48 ` Peter Zijlstra
2022-04-05 15:16 ` Dietmar Eggemann
2022-03-17 12:08 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjIN4C8EFIOOR+o4@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox