From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2E24C4332F for ; Thu, 17 Mar 2022 11:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233263AbiCQMAq (ORCPT ); Thu, 17 Mar 2022 08:00:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233240AbiCQMAo (ORCPT ); Thu, 17 Mar 2022 08:00:44 -0400 Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3C55173374; Thu, 17 Mar 2022 04:59:10 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id DA0B9580275; Thu, 17 Mar 2022 07:59:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 17 Mar 2022 07:59:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=NfFJnkbS3KtilmlXQThAwkw4X4l3eg9znnE/jO g1d5E=; b=N7X5g0pEnkMstgHhqa5+3+0BxTuLz3jVhklrKWMqTOsjegxrvnn1QH Fkdqg24A/ZPO41OAHum1syefQta0Tpi3oVmP5kV8Py12EHR0up9gRD2xvTI7uoa9 7D/+0PzOTRErTWQd+XprZVizUqWWf3YjC82AHS8ni1cN4R/C73z1BBPE2rw523xq CkhzuIOPZwqLTjDVqY+Tl5L4gurrdZTgGPc5tTx67ncRL66cXwhB27hSqx4gNDAO RZ7HOop1Tei6M11w1rk7aFAfewV/qSDpIngB2tqbdV695Du2NuMCHf483Fc56lRu XpAZErArtRSnJmaNcUU9QC+MM2mW82AQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=NfFJnkbS3KtilmlXQ ThAwkw4X4l3eg9znnE/jOg1d5E=; b=hD1Gz/uapIf/sWB9JNGq2bqENk7Jvi4hN Y0UvF1yhANVZFON0lDUCzuGbeJQLMNYy8rMbUNaasWYetsyeI8RvU3uVYj4G/XzV hUd5Xt4VKRDcFc61ktuXCtuBjJjZRG7JBly0e/6dGp3yI1SGxLcaOZjwaHxIlDA4 MCQZ17wR7waqIx3n6yPT7Nkq4wHiSw7ryxi53joG27ELAZYgNQNHr9WTnxaBm8dx G1hOwLABojoLiGHCZDlz8jcI4sY7YOOflgS19LdWg/S5JeIDA48MBIyHi0W/fcC4 HbFAqAW2y+HIOkoX0myj6dIWm3OjHtc5/MmzRn8d7UKlPO/eVgCZg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudefgedgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeevueehje fgfffgiedvudekvdektdelleelgefhleejieeugeegveeuuddukedvteenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhh drtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 17 Mar 2022 07:59:09 -0400 (EDT) Date: Thu, 17 Mar 2022 12:59:06 +0100 From: Greg KH To: Steffen Eiden Cc: agordeev@linux.ibm.com, borntraeger@linux.ibm.com, david@redhat.com, frankja@linux.ibm.com, gor@linux.ibm.com, hca@linux.ibm.com, imbrenda@linux.ibm.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org, nrb@linux.ibm.com, shuah@kernel.org Subject: Re: [PATCH v3 1/4] drivers/s390/char: Add Ultravisor io device Message-ID: References: <20220304141141.32767-2-seiden@linux.ibm.com> <20220317094706.4921-1-seiden@linux.ibm.com> <6175e7fa-070e-8ab2-843a-8019d0dc0c83@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6175e7fa-070e-8ab2-843a-8019d0dc0c83@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 17, 2022 at 12:07:58PM +0100, Steffen Eiden wrote: > Hi greg, > > On 3/17/22 10:59, Greg KH wrote: > > On Thu, Mar 17, 2022 at 09:47:06AM +0000, Steffen Eiden wrote: > > > This patch adds a new miscdevice to expose some Ultravisor functions > > > to userspace. Userspace can send IOCTLs to the uvdevice that will then > > > emit a corresponding Ultravisor Call and hands the result over to > > > userspace. The uvdevice is available if the Ultravisor Call facility is > > > present. > > > Userspace can call the Retrieve Attestation Measurement > > > Ultravisor Call using IOCTLs on the uvdevice. > > > > > > The uvdevice will do some sanity checks first. > > > Then, copy the request data to kernel space, build the UVCB, > > > perform the UV call, and copy the result back to userspace. > > > > > > Signed-off-by: Steffen Eiden > > > Reviewed-by: Janosch Frank > > > > Do you have a pointer to the userspace code that interacts with this > > kernel driver? That would be good to have to verify that the api here > > is sane. > > > There is a userspace tool currently under development, however, not yet > ready to be published. Then really, this driver should not be merged until the user/kernel api is determined to work properly, right? Why submit this now if userspace isn't working? thanks, greg k-h