Re: [PATCH v3 08/46] media: sun6i-csi: Tidy up Kconfig

Jernej Škrabec
2022-03-15T19:51:32Z

Dne petek, 11. marec 2022 ob 15:34:54 CET je Paul Kocialkowski napisal(a):
> Update the option title and help, group related options together,
> add dependency on VIDEO_DEV since the driver uses it.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> ---
> drivers/media/platform/sunxi/sun6i-csi/Kconfig | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/sunxi/sun6i-csi/Kconfig b/drivers/media/
platform/sunxi/sun6i-csi/Kconfig
> index fd03e48f0c8a..a88978eba455 100644
> --- a/drivers/media/platform/sunxi/sun6i-csi/Kconfig
> +++ b/drivers/media/platform/sunxi/sun6i-csi/Kconfig
> @@ -1,12 +1,13 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config VIDEO_SUN6I_CSI
> - tristate "Allwinner V3s Camera Sensor Interface driver"
> - depends on PM && VIDEO_V4L2 && COMMON_CLK && HAS_DMA
> + tristate "Allwinner A31 Camera Sensor Interface (CSI) Driver"
> depends on ARCH_SUNXI || COMPILE_TEST
> + depends on PM && COMMON_CLK && HAS_DMA
> + depends on VIDEO_DEV && VIDEO_V4L2
> + select REGMAP_MMIO
> select MEDIA_CONTROLLER
> select VIDEO_V4L2_SUBDEV_API
> select VIDEOBUF2_DMA_CONTIG
> - select REGMAP_MMIO
> select V4L2_FWNODE
> help
> - Support for the Allwinner Camera Sensor Interface Controller on
V3s.
> + Support for the Allwinner A31 Camera Sensor Interface (CSI)
controller.

While at it, it would be nice to somehow indicate that it's compatible with
more than one SoC.

Best regards,
Jernej

> --
> 2.35.1
>
>