Re: [PATCH 5/5 v2] dt-bindings: gnss: Rewrite Mediatek bindings in YAML

Krzysztof Kozlowski
2022-03-18T09:34:06Z

On 17/03/2022 23:58, Linus Walleij wrote:
> This rewrites the Mediatek GNSS bindings in YAML.
>
> Cc: devicetree@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - New patch since Krzysztof pointed out there is really just
> one more binding to convert, so why not.
> ---
> .../devicetree/bindings/gnss/mediatek.txt | 35 ------------
> .../devicetree/bindings/gnss/mediatek.yaml | 54 +++++++++++++++++++
> 2 files changed, 54 insertions(+), 35 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gnss/mediatek.txt
> create mode 100644 Documentation/devicetree/bindings/gnss/mediatek.yaml
>
> diff --git a/Documentation/devicetree/bindings/gnss/mediatek.txt b/Documentation/devicetree/bindings/gnss/mediatek.txt
> deleted file mode 100644
> index 80cb802813c5..000000000000
> --- a/Documentation/devicetree/bindings/gnss/mediatek.txt
> +++ /dev/null
> @@ -1,35 +0,0 @@
> -Mediatek-based GNSS Receiver DT binding
> -
> -Mediatek chipsets are used in GNSS-receiver modules produced by several
> -vendors and can use a UART interface.
> -
> -Please see Documentation/devicetree/bindings/gnss/gnss.txt for generic
> -properties.
> -
> -Required properties:
> -
> -- compatible : Must be
> -
> - "globaltop,pa6h"
> -
> -- vcc-supply : Main voltage regulator (pin name: VCC)
> -
> -Optional properties:
> -
> -- current-speed : Default UART baud rate
> -- gnss-fix-gpios : GPIO used to determine device position fix state
> - (pin name: FIX, 3D_FIX)

What happened with this property? It looks not used, but still I am not
sure we should remove it.

> -- reset-gpios : GPIO used to reset the device (pin name: RESET, NRESET)
> -- timepulse-gpios : Time pulse GPIO (pin name: PPS1, 1PPS)
> -- vbackup-supply : Backup voltage regulator (pin name: VBAT, VBACKUP)
> -
> -Example:
> -
> -serial@1234 {
> - compatible = "ns16550a";
> -
> - gnss {
> - compatible = "globaltop,pa6h";
> - vcc-supply = <&vcc_3v3>;
> - };
> -};
> diff --git a/Documentation/devicetree/bindings/gnss/mediatek.yaml b/Documentation/devicetree/bindings/gnss/mediatek.yaml
> new file mode 100644
> index 000000000000..273732225c1f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gnss/mediatek.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gnss/mediatek.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek GNSS Receiver Device Tree Bindings
> +
> +allOf:
> + - $ref: gnss-common.yaml#
> +
> +maintainers:
> + - Johan Hovold <johan@kernel.org>
> +
> +description:
> + Mediatek chipsets are used in GNSS-receiver modules produced by several
> + vendors and can use a UART interface.
> +
> +properties:
> + compatible:
> + const: globaltop,pa6h
> +
> + vcc-supply:
> + description:
> + Main voltage regulator, pin name VCC.
> +
> + reset-gpios:
> + maxItems: 1
> + description: An optional reset line, with names such as RESET or NRESET.
> + If the line is active low it should be flagged with GPIO_ACTIVE_LOW.
> +
> + timepulse-gpios:
> + description: Comes with pin names such as PPS1 or 1PPS.

This should not be needed here (same as patch #3). While changing it,
move also "allOf" just before properties.

Best regards,
Krzysztof