Re: linux-next: build warnings after merge of the tip tree

Masami Hiramatsu
2017-11-03T21:00:41Z

On Thu, 2 Nov 2017 13:53:51 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
>
> After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
> produced these warnings:
>
> net/dccp/probe.c: In function 'dccpprobe_init':
> net/dccp/probe.c:166:2: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> ret = register_jprobe(&dccp_send_probe);
> ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:471:32: note: declared here
> static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/dccp/probe.c:170:4: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> ret = register_jprobe(&dccp_send_probe);
> ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:471:32: note: declared here
> static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/dccp/probe.c: In function 'dccpprobe_exit':
> net/dccp/probe.c:190:2: warning: 'unregister_jprobe' is deprecated [-Wdeprecated-declarations]
> unregister_jprobe(&dccp_send_probe);
> ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:479:33: note: declared here
> static inline void __deprecated unregister_jprobe(struct jprobe *p)
> ^
> net/ipv4/tcp_probe.c: In function 'tcpprobe_init':
> net/ipv4/tcp_probe.c:280:2: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> ret = register_jprobe(&tcp_jprobe);
> ^
> In file included from net/ipv4/tcp_probe.c:24:0:
> include/linux/kprobes.h:471:32: note: declared here
> static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/ipv4/tcp_probe.c: In function 'tcpprobe_exit':
> net/ipv4/tcp_probe.c:298:2: warning: 'unregister_jprobe' is deprecated [-Wdeprecated-declarations]
> unregister_jprobe(&tcp_jprobe);
> ^
> In file included from net/ipv4/tcp_probe.c:24:0:
> include/linux/kprobes.h:479:33: note: declared here
> static inline void __deprecated unregister_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c: In function 'sctp_setup_jprobe':
> net/sctp/probe.c:189:2: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> int ret = register_jprobe(&sctp_recv_probe);
> ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:471:32: note: declared here
> static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c:194:3: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> ret = register_jprobe(&sctp_recv_probe);
> ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:471:32: note: declared here
> static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c: In function 'sctpprobe_exit':
> net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated [-Wdeprecated-declarations]
> unregister_jprobe(&sctp_recv_probe);
> ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:479:33: note: declared here
> static inline void __deprecated unregister_jprobe(struct jprobe *p)
> ^
>
> Introduced by commit
>
> 590c84593045 ("kprobes: Disable the jprobes APIs")
>
> These days we normally don't deprecate things, just remove them. But we
> do that *after* fixing up all the usages in the tree, please.

OK, should I remove __deprecated or revert above patch?
I pinged such users but no response. I can just rewrite it but not sure they can reply.

Thank you,

>
> --
> Cheers,
> Stephen Rothwell

--
Masami Hiramatsu <mhiramat@kernel.org>