Re: [PATCH 1/2] perf evsel: Make evsel__env always return a valid env

Arnaldo Carvalho de Melo
2022-03-22T21:36:56Z

Em Tue, Nov 23, 2021 at 01:56:38PM +0530, kajoljain escreveu:
>
>
> On 10/5/21 3:11 AM, Kim Phillips wrote:
> > It's possible to have an evsel and evsel->evlist populated without
> > an evsel->evlist->env, when, e.g., cmd_record is in its error path.
> >
> > Future patches will add support for evsel__open_strerror to be able
> > to customize error messaging based on perf_env__{arch,cpuid}, so
> > let's have evsel__env return &perf_env instead of NULL in that case.
> >
>
> Patch looks good to me.
>
> Reviewed-by: Kajol Jain<kjain@linux.ibm.com>

Collecting this one now, found it thru the cracks.

- Arnaldo

> Thanks,
> Kajol Jain
>
> > Signed-off-by: Kim Phillips <kim.phillips@amd.com>
> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > Cc: Ian Rogers <irogers@google.com>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Jiri Olsa <jolsa@redhat.com>
> > Cc: Joao Martins <joao.m.martins@oracle.com>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Michael Petlan <mpetlan@redhat.com>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Robert Richter <robert.richter@amd.com>
> > Cc: Stephane Eranian <eranian@google.com>
> > ---
> > tools/perf/util/evsel.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> > index dbfeceb2546c..b915840690d4 100644
> > --- a/tools/perf/util/evsel.c
> > +++ b/tools/perf/util/evsel.c
> > @@ -2857,7 +2857,7 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,
> >
> > struct perf_env *evsel__env(struct evsel *evsel)
> > {
> > - if (evsel && evsel->evlist)
> > + if (evsel && evsel->evlist && evsel->evlist->env)
> > return evsel->evlist->env;
> > return &perf_env;
> > }
> >

--

- Arnaldo