From: Borislav Petkov <bp@alien8.de>
To: "Chatradhi, Naveen Krishna" <nchatrad@amd.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org, mingo@redhat.com, mchehab@kernel.org,
airlied@linux.ie, Muralidhara M K <muralimk@amd.com>
Subject: Re: [PATCH 1/1] x86/amd_nb: unexport amd_cache_northbridges()
Date: Wed, 23 Mar 2022 16:31:43 +0100 [thread overview]
Message-ID: <Yjs9X4O3qwamG6ul@zn.tnic> (raw)
In-Reply-To: <31759627-1754-8d5d-6d6a-df3010d3e8e0@amd.com>
On Wed, Mar 23, 2022 at 08:54:20PM +0530, Chatradhi, Naveen Krishna wrote:
> Modules that are using this API comes after the fs_initcall() is called.
I don't need you to explain this to me - I need you to:
"What I am missing in this commit message is why is it ok to do that?"
I.e., pls explain in the commit message exactly why it is ok to do that
so that people who read it, will know.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-03-23 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 16:11 [PATCH 1/1] x86/amd_nb: unexport amd_cache_northbridges() Naveen Krishna Chatradhi
2022-03-15 17:28 ` Borislav Petkov
2022-03-23 15:24 ` Chatradhi, Naveen Krishna
2022-03-23 15:31 ` Borislav Petkov [this message]
2022-03-23 16:18 ` Chatradhi, Naveen Krishna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yjs9X4O3qwamG6ul@zn.tnic \
--to=bp@alien8.de \
--cc=airlied@linux.ie \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=muralimk@amd.com \
--cc=nchatrad@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox