From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F0AFC433EF for ; Wed, 23 Mar 2022 11:43:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243980AbiCWLpI (ORCPT ); Wed, 23 Mar 2022 07:45:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233748AbiCWLpH (ORCPT ); Wed, 23 Mar 2022 07:45:07 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31CEC36150; Wed, 23 Mar 2022 04:43:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B3525B81E7D; Wed, 23 Mar 2022 11:43:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6938C340E8; Wed, 23 Mar 2022 11:43:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1648035815; bh=WkV8XVmzLw63I9Fodwt+Z/8kLcUo4U+yhHdNLmmb6OM=; h=Date:From:To:Subject:References:In-Reply-To:From; b=H6e0rP9LCnJ63/4bOKhWvsfJt8D9JpW/36GSwu0akuxoBI/3EoqVOm886HE0u8cmV oWWIZZtdcBA2KALOQP8rsZhhPncqjPPdIx2fQDEcdyXnv5YD0fn0bm4ixnEbcQSKgV Uy6OtxyRh78m3ieuonTnfC3d4ksDxFZkOrFG/AJg= Date: Wed, 23 Mar 2022 12:43:32 +0100 From: Greg Kroah-Hartman To: Krzysztof Kozlowski , Jung Daehwan , Mathias Nyman , "open list:USB XHCI DRIVER" , open list , Howard Yen , Jack Pham , Puma Hsu , "J . Avila" , "chihhao . chen" , sc.suh@samsung.com, cpgs@samsung.com, cpgsproxy5@samsung.com Subject: Re: [PATCH v1 1/4] usb: host: export symbols for xhci hooks usage Message-ID: References: <1646375038-72082-1-git-send-email-dh10.jung@samsung.com> <252651381.41646375583002.JavaMail.epsvc@epcpadp4> <1983025922.01648006681661.JavaMail.epsvc@epcpadp4> <105eaeec-d77e-b0eb-86ad-a88c7446ca98@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <105eaeec-d77e-b0eb-86ad-a88c7446ca98@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 23, 2022 at 10:41:23AM +0100, Krzysztof Kozlowski wrote: > On 23/03/2022 03:58, Jung Daehwan wrote: > > On Mon, Mar 07, 2022 at 10:59:06AM +0100, Krzysztof Kozlowski wrote: > >> On 04/03/2022 07:23, Daehwan Jung wrote: > >>> Export symbols for xhci hooks usage: > >>> xhci_ring_free > >>> - Allow xhci hook to free xhci_ring. > >> > >> Instead of copying-pasting the name of function, please explain why do > >> you need these symbols exported. > >> > >> The "Why" is actually one of most important questions, because "what is > >> this patch doing" we can easily see... > >> > >>> > >>> xhci_get_slot_ctx > >>> - Allow xhci hook to get slot_ctx from the xhci_container_ctx > >>> for getting the slot_ctx information to know which slot is > >>> offloading and compare the context in remote subsystem memory > >>> if needed. > >>> > >> > >> > >> Best regards, > >> Krzysztof > >> > > > > Hi Krzysztof > > > > xhci_ring_free has been removed from v3.. > > The reason why I want to export is for managing vendor specific ring. > > I want to alloc and free vendor specific ring on specific address. > > It's done with xhci hooks. > > It's better, but still does not explain why these have to be exported. > Please mention where are these hooks going to be. Where are they > implemented. I actually expect all of these exports to be used in your > patchset. All exports _HAVE_ to be used by the patchset. Otherwise it's an invalid submission. thanks, greg k-h