From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA7ADC43219 for ; Wed, 23 Mar 2022 16:48:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245570AbiCWQuF (ORCPT ); Wed, 23 Mar 2022 12:50:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245566AbiCWQt7 (ORCPT ); Wed, 23 Mar 2022 12:49:59 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66A80BE27 for ; Wed, 23 Mar 2022 09:48:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A8BFBB81F67 for ; Wed, 23 Mar 2022 16:48:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 312B9C340E8; Wed, 23 Mar 2022 16:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648054099; bh=KZysVJrReQA7i1Z1nRSDq4ryI+V0LIK35Q/WCAy5knM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Kp0Ve9OH3/g0gQycRRJwUAl727z9uGUeetTB8IEQo4X9sqVNZ3Q2cZswd8Ncp9YFs l0lIZJoQGYohEDJjw2V7mkP65cBS/azJzO9PXy+q0YaCzY+Sp6xRBVHArVASk6PDqa R24FtNd2pjlMiUWtVeX/adzRoPj/xJqWx6KWT15EMq2UiTI5Dg6kaX2t0GpRvXbgC1 0A7suf+GxwDWZKyioMW7Vwl4QxmE3VcoHG0DCpkKmF+9KxWCl9F7//FlOr0RPO6KDH wqdoJuz0Tnm5Gm0leMonwMHRwv8niqJrlvjRnm4fHR4ZxTgVQhMP6d/y0VBd9DCuuF En/iOcQ7w/yNA== Date: Wed, 23 Mar 2022 09:48:17 -0700 From: Jaegeuk Kim To: Christoph Hellwig Cc: Linus Torvalds , Waiman Long , Linux Kernel Mailing List , Linux F2FS Dev Mailing List , Peter Zijlstra Subject: Re: [GIT PULL] f2fs for 5.18 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/23, Christoph Hellwig wrote: > On Tue, Mar 22, 2022 at 10:22:50AM -0700, Linus Torvalds wrote: > > On Mon, Mar 21, 2022 at 1:39 PM Jaegeuk Kim wrote: > > > > > > In this cycle, f2fs has some performance improvements for Android workloads such > > > as using read-unfair rwsems [...] > > > > I've pulled this, but that read-unfair rwsem code looks incredibly > > dodgy. Doing your own locking is always a bad sign, and it ahs > > traditionally come back to bite us pretty much every time. At least it > > uses real lock primitives, just in a really odd way. > > FYI, Peter and I both pointed this out when the patches were posted > and NAKed the patch, but the feedback was ignored. Christoph, I proposed, "I've been waiting for a generic solution as suggested here. Until then, I'd like to keep this in f2fs *only* in order to ship the fix in products. Once there's a right fix, let me drop or revise this patch again." https://lore.kernel.org/linux-f2fs-devel/YhZzV11+BlgI1PBd@google.com/