Re: [PATCH 2/3] Documentation: KVM: add virtual CPU errata documentation

Oliver Upton
2022-03-23T18:07:36Z

Hi Paolo,

On Tue, Mar 22, 2022 at 12:07:11PM +0100, Paolo Bonzini wrote:
> Add a file to document all the different ways in which the virtual CPU
> emulation is imperfect. Include an example to show how to document
> such errata.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

+100, this is excellent!

Reviewed-by: Oliver Upton <oupton@google.com>

> ---
> Documentation/virt/kvm/x86/errata.rst | 39 +++++++++++++++++++++++++++
> Documentation/virt/kvm/x86/index.rst | 1 +
> 2 files changed, 40 insertions(+)
> create mode 100644 Documentation/virt/kvm/x86/errata.rst
>
> diff --git a/Documentation/virt/kvm/x86/errata.rst b/Documentation/virt/kvm/x86/errata.rst
> new file mode 100644
> index 000000000000..df394d34a836
> --- /dev/null
> +++ b/Documentation/virt/kvm/x86/errata.rst
> @@ -0,0 +1,39 @@
> +
> +=======================================
> +Known limitations of CPU virtualization
> +=======================================

In an attempt for us KVM developers to save face, would it make
sense to rip the table for KVM_CAP_DISABLE_QUIRKS2 out of api.rst and
drop it here?

That way, we can discuss all of the known errata in KVM *and* mention
the chicken bits we provide to mitigate :)

--
Thanks,
Oliver