From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C186FC433EF for ; Thu, 24 Mar 2022 08:32:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348924AbiCXIdr (ORCPT ); Thu, 24 Mar 2022 04:33:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244857AbiCXIdq (ORCPT ); Thu, 24 Mar 2022 04:33:46 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6FA69BB90 for ; Thu, 24 Mar 2022 01:32:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9E863B82293 for ; Thu, 24 Mar 2022 08:32:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D47DCC340EC; Thu, 24 Mar 2022 08:32:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1648110730; bh=1PYX7RVaDZHNEfu+LnaQqMTtbG6CsOpb6IVsMKlDkw4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iFk+7ObOuXWfJ4q8uX+THXAAmRdgFtUejNssCFZiD1IPz8cvy5LQYo+kBh535bl0J YXVNX7ym5woMJHaWatSmuhVZN94nW9vwh0Zzddg2lS+HMp17Buby3PjIi/4j2Yo8UF pbfdXcXalfdeH2Fw8cIh9NpvL5jrbwmYC8jGKG00= Date: Thu, 24 Mar 2022 09:32:07 +0100 From: Greg Kroah-Hartman To: Oh Eomji Cc: Jaroslav Kysela , Takashi Iwai , open list , alsa-devel@alsa-project.org, Leon Romanovsky , Pavel Skripkin , JaeHun Jung Subject: Re: [PATCH v1 1/3] sound: usb: Add vendor's hooking interface Message-ID: References: <1648109444-196321-1-git-send-email-eomji.oh@samsung.com> <1648109444-196321-2-git-send-email-eomji.oh@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1648109444-196321-2-git-send-email-eomji.oh@samsung.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 24, 2022 at 05:10:42PM +0900, Oh Eomji wrote: > In mobile, a co-processor can be used with USB audio to improve power > consumption. To support this type of hardware, hooks need to be added > to the USB audio subsystem to be able to call into the hardware when > needed. > > The main operation of the call-backs are: > - Initialize the co-processor by transmitting data when initializing. > - Change the co-processor setting value through the interface > function. > - Configure sampling rate > - pcm open/close > - other housekeeping > > Known issues: > - This only supports one set of callback hooks, meaning that this only > works if there is one type of USB controller in the system. This > should be changed to be a per-host-controller interface instead of > one global set of callbacks. Sorry, but this limitation alone means that this is not going to be able to be accepted. Almost all real systems have multiple USB controllers in the system and so, this will break in very bad ways on the majority of devices in the world. Please fix this up and make this per-USB-controller, as was requested the last time this series was published. thanks, greg k-h