From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D006BC433EF for ; Fri, 8 Apr 2022 02:15:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233718AbiDHCR3 (ORCPT ); Thu, 7 Apr 2022 22:17:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233698AbiDHCR1 (ORCPT ); Thu, 7 Apr 2022 22:17:27 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC86C273378 for ; Thu, 7 Apr 2022 19:15:23 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 585305C013B; Thu, 7 Apr 2022 22:15:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 07 Apr 2022 22:15:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; bh=nvkFaMbev4/kVyqnJNPqVSo+frUbKl NHC+DpOIWGrBw=; b=Png8i7qUPf5HmJFJ58DmULMRRGYoAmB73A3ZOYEqFUm1fU 43PFXFKD9iepd1G5yZsz9+lMRJAQS+DLN/POwV1J7BJcjFkwz59ZIw9mRnGUwlZf Ctmdp0B0Mlqd+9uY+KT/Tyo2fQstOHWVit5j3YtALZkV35WE9UFuUFLCQxj3FZyz K6CAF8zwT+X7sLrJIUXQnsl9qILn2iBGw0VHpdRKJC1Gz0qtaCQgra4rauaBPeWN RHnLssQtAL378A+ibP0ZN1Hb1LTsKjEVApYDLUggi6QxyFkvw+q59/c37vStoKf1 pnyPBufUAUHiDOTySi/VebnjcCrd/hiXROBSZnOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=nvkFaMbev4/kVyqnJ NPqVSo+frUbKlNHC+DpOIWGrBw=; b=DKeAQHx6rcKdL75fyOgCawkzYIYKN2p7X 10oUueW8uqnBWhrF8gXHfytM87wfwhpkeFUtGtnyb5e+TC9Hu8YyaXi3fvT3mcMG PmGAS52g2HN5SXbpqfujsnWEk/Cqb9RY6ekbGCUdxtj2VmQTt+T82wp1b3PpD7u8 0BhFuD9x3xOuwBICffODz7F4IeiqBsc3EaJpbFleXZSH3Uv5Xvr+2Q7jh5WTtwzc xJ3xq/Cabyat4SD0cFcnZlNVjKorCobwz/tU4XP3I8pGD5xCb2GL5HjpqMsCmn8G 8uF2Log6rcbW5V6kUKC9Zhdp7pZXEIbOGwGYstIUaNDN7qfia2kcw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejledghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefvrghkrghs hhhiucfurghkrghmohhtohcuoehoqdhtrghkrghshhhisehsrghkrghmohgttghhihdrjh hpqeenucggtffrrghtthgvrhhnpeejgeeifeeuveeufeeigeegjeelvdfgjeegffejgfdv keelhefgtdefteejleekjeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepohdqthgrkhgrshhh ihesshgrkhgrmhhotggthhhirdhjph X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Apr 2022 22:15:19 -0400 (EDT) Date: Fri, 8 Apr 2022 11:15:16 +0900 From: Takashi Sakamoto To: Takashi Iwai Cc: clemens@ladisch.de, alsa-devel@alsa-project.org, linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/3] firewire: assist unit driver to compute packet time stamp Message-ID: Mail-Followup-To: Takashi Iwai , clemens@ladisch.de, alsa-devel@alsa-project.org, linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20220405072221.226217-1-o-takashi@sakamocchi.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 07, 2022 at 08:02:10AM +0200, Takashi Iwai wrote: > On Thu, 07 Apr 2022 02:10:21 +0200, > Takashi Sakamoto wrote: > > > > On Tue, Apr 05, 2022 at 06:23:35PM +0200, Takashi Iwai wrote: > > > On Tue, 05 Apr 2022 09:22:18 +0200, > > > Takashi Sakamoto wrote: > > > > > > > > Hi, > > > > > > > > Current implementation of Linux FireWire subsystem doesn't allow unit > > > > driver to operate content of packet in IR context according to > > > > time stamp. Additionally it doesn't allow unit driver to read current value > > > > of CYCLE_TIME register in OHCI 1394 controller. It brings disadvantages to > > > > drivers in Linux sound subsystem in regards of handling time for sampled > > > > data such as PCM frames and MIDI messages. > > > > > > > > This rerolled patchset is first step to improve the situation. > > > > > > > > Changes in v3: > > > > * Rebase v2 patchset to v5.18-rc1 > > > > Changes in v2: > > > > * Rebase v1 patchset to v5.16 release > > > > * https://lore.kernel.org/lkml/20220212022131.199855-1-o-takashi@sakamocchi.jp/ > > > > V1: > > > > * https://lore.kernel.org/lkml/20211202113457.24011-1-o-takashi@sakamocchi.jp/ > > > > > > > > Hector Martin (1): > > > > firewire: Add dummy read_csr/write_csr functions > > > > > > > > Takashi Sakamoto (2): > > > > firewire: add kernel API to access CYCLE_TIME register > > > > firewire: add kernel API to access packet structure in request > > > > structure for AR context > > > > > > Thanks, applied all three patches now to for-next branch. > > > > Although thanks for your applying them into your tree, I apologize to > > trouble you if you overlook that the included changes is just for Linux > > FireWire subsystem. It's my fault to send them only to Linux sound > > subsystem, but the changes are required to my work in sound drivers... > > > > If you are willing to include patches to Linux FireWire subsystem for > > your pull-request to Linus, I can prepare respined patches for it since > > I have the list of patches posted to LKML as bug fixes for Linux FireWire > > subsystem. > > > > I need any help to solve current situation of Linux FireWire subsystem > > that bug fixes and new changes are hardly merged. Of course, IEEE 1394 bus > > is already outdated and legacy, but I know that some users still work > > with it. If your path is available for it, it's the easiest and the most > > convenient way for upstreaming, I think. > > Ah OK, it's fine for me in either way. I can keep up those changes in > my tree, or go through others. I leave the decision Firewire > subsystem people. Just let me know. That's great. I think we can see few objections. In this weekend, I'll send two respined patchset. One is for bug fixes for your for-linus and living stables. Another is for your linux-next. Thanks for your kindness. Takashi Sakamoto