From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Fabio Baltieri <fabiobaltieri@chromium.org>
Cc: "Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lee Jones" <lee.jones@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
chrome-platform@lists.linux.dev, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] drivers: pwm: pwm-cros-ec: add channel type support
Date: Wed, 6 Apr 2022 03:07:43 +0000 [thread overview]
Message-ID: <Yk0D/4vzOfR8H+YD@google.com> (raw)
In-Reply-To: <20220331125818.3776912-3-fabiobaltieri@chromium.org>
On Thu, Mar 31, 2022 at 12:58:16PM +0000, Fabio Baltieri wrote:
> Add support for EC_PWM_TYPE_DISPLAY_LIGHT and EC_PWM_TYPE_KB_LIGHT pwm
> types to the PWM cros_ec_pwm driver. This allows specifying one of these
> PWM channel by functionality, and let the EC firmware pick the correct
> channel, thus abstracting the hardware implementation from the kernel
> driver.
>
> Signed-off-by: Fabio Baltieri <fabiobaltieri@chromium.org>
Taking `git log --oneline drivers/pwm/pwm-cros-ec.c` as examples, suggest to
remove "drivers: " prefix from the commit title.
Otherwise,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
next prev parent reply other threads:[~2022-04-06 9:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 12:58 [PATCH v2 0/4] Add channel type support to pwm-cros-ec Fabio Baltieri
2022-03-31 12:58 ` [PATCH v2 1/4] dt-bindings: add mfd/cros_ec definitions Fabio Baltieri
2022-03-31 12:58 ` [PATCH v2 2/4] drivers: pwm: pwm-cros-ec: add channel type support Fabio Baltieri
2022-04-06 3:07 ` Tzung-Bi Shih [this message]
2022-03-31 12:58 ` [PATCH v2 3/4] dt-bindings: update google,cros-ec-pwm documentation Fabio Baltieri
2022-04-06 15:41 ` Rob Herring
2022-04-07 14:38 ` Fabio Baltieri
2022-04-07 16:49 ` Rob Herring
2022-04-07 19:36 ` Fabio Baltieri
2022-03-31 12:58 ` [PATCH v2 4/4] arm64: dts: address cros-ec-pwm channels by type Fabio Baltieri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yk0D/4vzOfR8H+YD@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=fabiobaltieri@chromium.org \
--cc=groeck@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox