The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Patrice Chotard <patrice.chotard@foss.st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: Re: [PATCH v1 1/1] media: c8sectpfe: Clean up handling of *_buffer_aligned
Date: Wed, 6 Apr 2022 16:37:40 +0300	[thread overview]
Message-ID: <Yk2XpEaRiVylkXEt@smile.fi.intel.com> (raw)
In-Reply-To: <20220308171005.GA365233@gnbcxd0016.gnb.st.com>

On Tue, Mar 08, 2022 at 06:10:05PM +0100, Alain Volmat wrote:
> Hi Andy,
> 
> sorry for the delay.
> 
> Reviewed-by: Alain Volmat <alain.volmat@foss.st.com>

Thanks!

Can it be applied now?

> On Tue, Mar 08, 2022 at 12:25:42PM +0200, Andy Shevchenko wrote:
> > On Wed, Mar 02, 2022 at 05:51:42PM +0200, Andy Shevchenko wrote:
> > > On Wed, Feb 09, 2022 at 08:25:21PM +0200, Andy Shevchenko wrote:
> > > > There are a few cases where code is harder than needed to read.
> > > > Improve those by:
> > > > - dropping unnecessary castings (see note below)
> > > > - use PTR_ALING() to be more explicit on what's going on there
> > > > - use proper definitions instead of hard coded values
> > > > 
> > > > Note, dropping castings will allow to perform an additional check
> > > > that type is not changed from void * to something else, e.g. u64,
> > > > which may very well break the bitmap APIs.
> > > 
> > > Any comments on it?

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2022-04-06 16:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09 18:25 [PATCH v1 1/1] media: c8sectpfe: Clean up handling of *_buffer_aligned Andy Shevchenko
2022-03-02 15:51 ` Andy Shevchenko
2022-03-08 10:25   ` Andy Shevchenko
2022-03-08 17:10     ` Alain Volmat
2022-04-06 13:37       ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yk2XpEaRiVylkXEt@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=patrice.chotard@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox