From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 192C3C433FE for ; Wed, 6 Apr 2022 18:00:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239731AbiDFSCL (ORCPT ); Wed, 6 Apr 2022 14:02:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240019AbiDFSB4 (ORCPT ); Wed, 6 Apr 2022 14:01:56 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F16521F6BFF for ; Wed, 6 Apr 2022 09:34:37 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id r7so1848581wmq.2 for ; Wed, 06 Apr 2022 09:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=H/+oJ8TjZVOd1l75IwzMMMXtvl7GXkrbfQ+DzHiFQYU=; b=BMwxs+Vef9vLfaw6yy3+lZv2gw/NvY1Ch0P1iCzk84RmbzDKCWJPYIR8WNlr6XNKDO QItKWXjhGTc1KHbw5C0A26WCg2ntg+4lA+vCMtJ3LnKvvDKxCnJCD+Ns08p3dFfu5n8S ozafxpD0PkXVLgGuXBUd1a1SrWkFbV+K9nw/ozkJAh5hcPG0tK7ruX3ZzEPnqxI6fIVk GAOCfcuRGPHuvVbVNUf8I8KmQ3qMkfDKpLP4mkv2KkDAoLbt9SvODQo+SvE4rxiOPSy4 i+/BsJxCveTtTofLob7zly8NBOJyAadC1dkDhkkJuMjFo0KjPRPcJZu0yxBsK6YEJU5B nG7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=H/+oJ8TjZVOd1l75IwzMMMXtvl7GXkrbfQ+DzHiFQYU=; b=1MnP9hPFfTtdnN/xalYhR/V4HfJbfpiP4RtLLfXTt7wAXNJhb0ZHKRc5RgmcZnrjUa sBwq0eINZzdkp/MAu5hVZ4S7XmRABrhctS9VHat9pqqIXOel0YR1lCR0fF8z8M22jm0w EtvcrHpn2jkcZrEzL4u9zXbnhE5bfTP8vLV+/MlieRzwVQWmDhstpJeDnn3/MLx5G3QU Ro4PQzLruASSe24mow0DS/XTu1XN+psg9xZKKWlSgrJi7erB97n56xLabyhU0TamKxWg 0owGM6D6zv37MMxLQa4aiHMOGIlyv1Vfhv3FWaN60ucxw6UgqLNzRdNu7QvDevzULR/a QbRg== X-Gm-Message-State: AOAM533+hdUDcAABFPoMpWQca3xfA+Ce1OFd/jUy9ilYBise22Gl0TDi cdwkgEg5LYI/KwvvU8xWbWeqkA== X-Google-Smtp-Source: ABdhPJy9yeGEAv39yBSx3Sa8U7lCyrtZAHxLX4W3Or999FIlZcvdqo5vIB0FWcdQCyuCMy+Br8o/Dg== X-Received: by 2002:a05:600c:228f:b0:38e:74f7:a0fb with SMTP id 15-20020a05600c228f00b0038e74f7a0fbmr8334112wmf.39.1649262876338; Wed, 06 Apr 2022 09:34:36 -0700 (PDT) Received: from google.com (216.131.76.34.bc.googleusercontent.com. [34.76.131.216]) by smtp.gmail.com with ESMTPSA id bg20-20020a05600c3c9400b0037fa5c422c8sm5839444wmb.48.2022.04.06.09.34.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 09:34:36 -0700 (PDT) Date: Wed, 6 Apr 2022 16:34:34 +0000 From: Sebastian Ene To: Rob Herring Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Guenter Roeck , Wim Van Sebroeck , Rob Herring , qperret@google.com, maz@kernel.org, linux-watchdog@vger.kernel.org, will@kernel.org Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add qemu,vm-watchdog compatible Message-ID: References: <20220405141954.1489782-1-sebastianene@google.com> <20220405141954.1489782-2-sebastianene@google.com> <1649247924.294947.2048303.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1649247924.294947.2048303.nullmailer@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 06, 2022 at 07:25:24AM -0500, Rob Herring wrote: > On Tue, 05 Apr 2022 14:19:54 +0000, Sebastian Ene wrote: > > This watchdog can be used to detect stalls on vCPUs. > > > > Signed-off-by: Sebastian Ene > > --- > > .../devicetree/bindings/watchdog/vm-wdt.yaml | 44 +++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/watchdog/vm-wdt.yaml > > Hello Rob, > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/watchdog/vm-wdt.yaml: properties:timeout-sec: '$ref' should not be valid under {'const': '$ref'} > hint: Standard unit suffix properties don't need a type $ref > from schema $id: http://devicetree.org/meta-schemas/core.yaml# > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/watchdog/vm-wdt.yaml: ignoring, error in schema: properties: timeout-sec > Documentation/devicetree/bindings/watchdog/vm-wdt.example.dtb:0:0: /example-0/watchdog: failed to match any schema with compatible: ['qemu,vm-watchdog'] > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/ > I will fix them, thanks for letting me know. > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > Cheers, Sebastian