From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E3B3C433EF for ; Wed, 6 Apr 2022 23:36:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237829AbiDFXh4 (ORCPT ); Wed, 6 Apr 2022 19:37:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237595AbiDFXhs (ORCPT ); Wed, 6 Apr 2022 19:37:48 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 702A01E520E for ; Wed, 6 Apr 2022 16:35:50 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id fu5so3996877pjb.1 for ; Wed, 06 Apr 2022 16:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=I9PXYYNYzm+S86XiDohEIIjS7uODRi+inUQ+moEyXoI=; b=AHE5qokLSDutFR7PI8eQWDwxmxlJzrKafDW0/fFJ5EL9eN5tG8Ib+nvmPWjLccswFO LeBMTI+eySDNC30XqN9ueFi938W7I4yq1ZS7LJMpYY2vAy6DD2krEQIuakJkRHmOJJD2 2qW51WjOrAwtImJkE7bXt2zuDlMIeuMjonTWrp3LI/f6WeyMKYbGgBfORrKDMu4Y+ncd mtIpb5SSZ1XD4hMusUwFvUsQKFZarjSi4MYhbgkAr9DFzNmGqd8C3uqsV2cJUaXlgJ2q zwFw0KCxkoz9Gs0Mw+T9ysOWDwHhd4H9pUeN/qtavuciYsE4ZXb/RYcYThkdLG2hffah uAWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=I9PXYYNYzm+S86XiDohEIIjS7uODRi+inUQ+moEyXoI=; b=nrPljf36RV6dOvz7keNgf3VfsMQ72OTvYDoK/wFBrni9cNQIk1jjrpuaXEHS4NWz55 DegzQzDX6XnIsuuztVyrAAMs7+kjN9d6I1Cn0F2b26MgPdhdHjvDkL2MBtJ3O8m9CeN5 7xnRuTyJJooR3LzXf0fYck/YGSel2QBQa0w1F1fhLmAPcl3RHXci6ybzw5cSLf0VpcfW lPxpNARTY2EvYxx85JdaFsKCAmLHH66sTDI62cl6IZdu2XAGx5a6aUtt4hxThnZIc3nu Hdv3Rn3cH3x97Xxht1WW8V/afquTYHl6NbMZknPlYL6xCuZjsokhRmRFebh8KIxRKYjx iTUQ== X-Gm-Message-State: AOAM533fVd8XGYJzTeNEW+h/TdiKbVK7uSoz5z1WfzIv8eFRn0udlDcJ YKaa5X4keo+NUS7at4JDjXMN3Q== X-Google-Smtp-Source: ABdhPJy16UR83rlEq9AhsRifZ1oBb2UHMARMltuDdLjmXLfxa1VkMpUIcuOE413C9cxMtZqmFWNWpw== X-Received: by 2002:a17:902:d48f:b0:156:bddf:ef8 with SMTP id c15-20020a170902d48f00b00156bddf0ef8mr11085044plg.83.1649288149820; Wed, 06 Apr 2022 16:35:49 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id m15-20020a638c0f000000b003827bfe1f5csm17030090pgd.7.2022.04.06.16.35.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 16:35:49 -0700 (PDT) Date: Wed, 6 Apr 2022 23:35:45 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: isaku.yamahata@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com, Jim Mattson , erdemaktas@google.com, Connor Kuehl Subject: Re: [RFC PATCH v5 045/104] KVM: x86/tdp_mmu: make REMOVED_SPTE include shadow_initial value Message-ID: References: <6614d2a2bc34441ed598830392b425fdf8e5ca52.1646422845.git.isaku.yamahata@intel.com> <3f93de19-0685-3045-22db-7e05492bb5a4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f93de19-0685-3045-22db-7e05492bb5a4@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 05, 2022, Paolo Bonzini wrote: > On 3/4/22 20:49, isaku.yamahata@intel.com wrote: > > @@ -207,9 +209,17 @@ extern u64 __read_mostly shadow_nonpresent_or_rsvd_mask; > > /* Removed SPTEs must not be misconstrued as shadow present PTEs. */ > > static_assert(!(REMOVED_SPTE & SPTE_MMU_PRESENT_MASK)); > > +/* > > + * See above comment around REMOVED_SPTE. SHADOW_REMOVED_SPTE is the actual > > + * intermediate value set to the removed SPET. When TDX is enabled, it sets > > + * the "suppress #VE" bit, otherwise it's REMOVED_SPTE. > > + */ > > +extern u64 __read_mostly shadow_init_value; > > +#define SHADOW_REMOVED_SPTE (shadow_init_value | REMOVED_SPTE) > > Please rename the existing REMOVED_SPTE to REMOVED_SPTE_MASK, and call this > simply REMOVED_SPTE. This also makes the patch smaller. Can we name it either __REMOVE_SPTE or REMOVED_SPTE_VAL? It's most definitely not a mask, it's a full value, e.g. spte |= REMOVED_SPTE_MASK is completely wrong. Other than that, 100% agree with avoiding churn.