public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Pavel Machek <pavel@denx.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 1/2] mmc: renesas_sdhi: Jump to error path instead of returning directly
Date: Thu, 7 Apr 2022 09:13:19 +0200	[thread overview]
Message-ID: <Yk6PD/aHJMfTlcjv@ninjato> (raw)
In-Reply-To: <OS0PR01MB5922C35E8C5259C3DA2A951A86E59@OS0PR01MB5922.jpnprd01.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]


> I guess it has to move up, first get reset handle and clock handle and return error
> directly in case of error, Then do clk/reset ops. 
> 
> > 
> > Wolfram, what is your preference on the above?

Yes, moving up makes sense. First check all the handles before we
actually initialize the hardware.

Thanks for pointing all this out.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2022-04-07  7:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-04 17:23 [PATCH 0/2] mmc: renesas: Trivial fixes Lad Prabhakar
2022-04-04 17:23 ` [PATCH 1/2] mmc: renesas_sdhi: Jump to error path instead of returning directly Lad Prabhakar
2022-04-04 18:02   ` Biju Das
2022-04-04 18:08     ` Lad, Prabhakar
2022-04-04 18:12       ` Biju Das
2022-04-05  3:51         ` Lad, Prabhakar
2022-04-07  7:13         ` Wolfram Sang [this message]
2022-04-04 17:23 ` [PATCH 2/2] mmc: renesas_internal_dmac: Fix typo's Lad Prabhakar
2022-04-04 18:21   ` Wolfram Sang
2022-04-05  3:50     ` Lad, Prabhakar
2022-04-05  4:45       ` Wolfram Sang
2022-04-05  5:13         ` Lad, Prabhakar
2022-04-05  7:18         ` Geert Uytterhoeven
2022-06-21 13:35 ` [PATCH 0/2] mmc: renesas: Trivial fixes Wolfram Sang
2022-06-21 14:03   ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yk6PD/aHJMfTlcjv@ninjato \
    --to=wsa+renesas@sang-engineering.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=pavel@denx.de \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=ulf.hansson@linaro.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox