From: Greg KH <gregkh@linuxfoundation.org>
To: xkernel.wang@foxmail.com
Cc: paskripkin@gmail.com, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] staging: r8188eu: check the return of kzalloc()
Date: Thu, 7 Apr 2022 19:51:00 +0200 [thread overview]
Message-ID: <Yk8khN/Htc0zVY9d@kroah.com> (raw)
In-Reply-To: <tencent_0D5C6E0E160AA0702025FDFF35906EE69E07@qq.com>
On Thu, Apr 07, 2022 at 10:03:49AM +0800, xkernel.wang@foxmail.com wrote:
> On Thursday, April 7, 2022 3:22 AM +0800, paskripkin@gmail.com wrote:
> > > -void rtw_alloc_hwxmits(struct adapter *padapter)
> > > +s32 rtw_alloc_hwxmits(struct adapter *padapter)
> > > {
> >
> > What about plain 'int'? I know that s32 is typedef for 'int', but 'int'
> > looks more natural
> >
>
> I agree with you.
> Since the type of `_rtw_init_xmit_priv` is `s32`, I directly changed the
> type of `rtw_alloc_hwxmits` to `s32` (they are neighbors in rtw_xmit.h).
> In fact, there are many places where `s32` appears together with `int`
> in related files, so maybe we can leave it as a future work to make all
> of them a unified form.
No, get this one right to start with.
thanks,
greg k-h
prev parent reply other threads:[~2022-04-07 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 4:29 [PATCH v2 1/2] staging: r8188eu: fix potential memory leak in _rtw_init_xmit_priv() xkernel.wang
2022-04-06 4:30 ` [PATCH v2 2/2] staging: r8188eu: check the return of kzalloc() xkernel.wang
2022-04-06 19:22 ` Pavel Skripkin
2022-04-07 2:03 ` xkernel.wang
2022-04-07 17:51 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yk8khN/Htc0zVY9d@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=xkernel.wang@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox