Re: [PATCH] x86/config: Make the x86 defconfigs a bit more usable

Ingo Molnar
2022-03-27T19:04:16Z

* Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Thu, Mar 24, 2022 at 08:47:27AM -0700, Nathan Chancellor wrote:
> > On Thu, Mar 24, 2022 at 09:31:13AM +0100, Ingo Molnar wrote:
>
> > > --- a/arch/x86/configs/i386_defconfig
> > > +++ b/arch/x86/configs/i386_defconfig
>
> > > -# CONFIG_64BIT is not set
> >
> > I don't think this is right, this is repeating the problem that was
> > fixed by commit 76366050eb1b ("x86/defconfigs: Explicitly unset
> > CONFIG_64BIT in i386_defconfig").
> >
> > $ make ARCH=i386 savedefconfig
> >
> > ?
>
> +1 here, there are still branches in use that have i386 defconfig as
> as base and making this problem again is not okay.

Absolutely - fixed in the latest version.

Thanks,

Ingo