* [PATCH V2] staging: r8188eu: Directly return _FAIL instead of using local ret variable
@ 2022-03-28 8:43 Haowen Bai
2022-03-28 8:48 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Haowen Bai @ 2022-03-28 8:43 UTC (permalink / raw)
To: Larry.Finger, phil, gregkh, straube.linux, martin
Cc: linux-staging, linux-kernel, Haowen Bai
fixes coccinelle warning:
./drivers/staging/r8188eu/core/rtw_mlme_ext.c:1518:14-17: Unneeded variable: "ret".
Return "_FAIL" on line 1549
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
V1->V2: split into two patches.
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 10d5f12..931e6f2 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -1515,7 +1515,6 @@ unsigned int OnAtim(struct adapter *padapter, struct recv_frame *precv_frame)
unsigned int on_action_spct(struct adapter *padapter, struct recv_frame *precv_frame)
{
- unsigned int ret = _FAIL;
struct sta_info *psta = NULL;
struct sta_priv *pstapriv = &padapter->stapriv;
u8 *pframe = precv_frame->rx_data;
@@ -1546,7 +1545,7 @@ unsigned int on_action_spct(struct adapter *padapter, struct recv_frame *precv_f
}
exit:
- return ret;
+ return _FAIL;
}
unsigned int OnAction_qos(struct adapter *padapter, struct recv_frame *precv_frame)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH V2] staging: r8188eu: Directly return _FAIL instead of using local ret variable
2022-03-28 8:43 [PATCH V2] staging: r8188eu: Directly return _FAIL instead of using local ret variable Haowen Bai
@ 2022-03-28 8:48 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2022-03-28 8:48 UTC (permalink / raw)
To: Haowen Bai
Cc: Larry.Finger, phil, straube.linux, martin, linux-staging,
linux-kernel
On Mon, Mar 28, 2022 at 04:43:42PM +0800, Haowen Bai wrote:
> fixes coccinelle warning:
> ./drivers/staging/r8188eu/core/rtw_mlme_ext.c:1518:14-17: Unneeded variable: "ret".
> Return "_FAIL" on line 1549
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> V1->V2: split into two patches.
>
> drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> index 10d5f12..931e6f2 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> @@ -1515,7 +1515,6 @@ unsigned int OnAtim(struct adapter *padapter, struct recv_frame *precv_frame)
>
> unsigned int on_action_spct(struct adapter *padapter, struct recv_frame *precv_frame)
> {
> - unsigned int ret = _FAIL;
> struct sta_info *psta = NULL;
> struct sta_priv *pstapriv = &padapter->stapriv;
> u8 *pframe = precv_frame->rx_data;
> @@ -1546,7 +1545,7 @@ unsigned int on_action_spct(struct adapter *padapter, struct recv_frame *precv_f
> }
>
> exit:
> - return ret;
> + return _FAIL;
Something is wrong here, why would this function always fail? Are you
sure that this is working properly?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-28 8:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-28 8:43 [PATCH V2] staging: r8188eu: Directly return _FAIL instead of using local ret variable Haowen Bai
2022-03-28 8:48 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox