Re: [PATCH 5.10 09/38] llc: fix netdevice reference leaks in llc_ui_bind()

Pavel Machek
2022-03-28T09:37:12Z

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

Hi!

> > > > commit 2d327a79ee17 ("llc: only change llc->dev when bind() succeeds"),
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=2d327a79ee176930dc72c131a970c891d367c1dc
> > > >
> > > > Should be in mainline on Thursday, LMK if we need to accelerate.
> > > > IDK if anyone enables LLC2.
> > >
> > > I'll queue this up now, thanks.
> >
> > As the changelog says, this needs b37a46683739, otherwise there will
> > be oops-es in even more cases.
>
> If you look at the change, I think I already handled that issue. If
> not, please let me know.

Actually, AFAICT it will now oops even in the common (non-error) path
in llc_ui_autobind().

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]