Re: [PATCH] soc: soc-dapm: fix two incorrect uses of list iterator

Mark Brown
2022-03-28T16:32:03Z

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

On Sun, Mar 27, 2022 at 04:21:38PM +0800, Xiaomeng Tong wrote:

> case snd_soc_dapm_pre:
> - if (!w->event)
> + if (!w->event) {
> list_for_each_entry_safe_continue(w, n, list,
> power_list);
> + break;
> + }

This doesn't make much sense. The intent here seems to clearly be to
continue; the loop but this doesn't do that - instead it appears that
continue doesn't actually do the equivalent of a continue but rather
skips over an entry. This should instead be replaced with a plain
continue statement.

THe naming of _continue() needs fixing I think - it's just asking to be
a bug. Fortunately there's very few users.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]