From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E4D6C433F5 for ; Tue, 29 Mar 2022 09:56:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234898AbiC2J6M (ORCPT ); Tue, 29 Mar 2022 05:58:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231864AbiC2J6K (ORCPT ); Tue, 29 Mar 2022 05:58:10 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D40B9E9E9 for ; Tue, 29 Mar 2022 02:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=pJFbieYuMliDkorM/V/PDbhfFVJI 4OfwO+V1QhjgIjI=; b=FTCfDTMel3Y0xfBFes0gT9fT1cbL485/LVqU1dPzzEIX 21iJL573t/oUpScLaRVSknihh7GZNAUreCGodX9U1P44S6Qv/CS4JWKX20C+Gsyr cdLnHadYSxGaOn6NzDhGY9/0wjy+kn567cy+XHOcT/rhhfoeHF8gsADLM6wPIVc= Received: (qmail 1736111 invoked from network); 29 Mar 2022 11:56:26 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 29 Mar 2022 11:56:26 +0200 X-UD-Smtp-Session: l3s3148p1@yf0ycVjbXKggAQnoAFHmAKNSQL+AeJes Date: Tue, 29 Mar 2022 11:56:26 +0200 From: Wolfram Sang To: Geert Uytterhoeven Cc: Krzysztof Kozlowski , Sergey Shtylyov , Dung Nguyen , Lad Prabhakar , Andrew Gabbasov , Mark Brown , linux-renesas-soc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] memory: renesas-rpc-if: Fix HF/OSPI data transfer in Manual mode Message-ID: Mail-Followup-To: Wolfram Sang , Geert Uytterhoeven , Krzysztof Kozlowski , Sergey Shtylyov , Dung Nguyen , Lad Prabhakar , Andrew Gabbasov , Mark Brown , linux-renesas-soc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1HwUNj8StJmyV25U" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --1HwUNj8StJmyV25U Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Geert, thank you for this update! > - Update comments to match changed code, > - Add explicit {read,write}l() for the 4/8 byte case, to increase > readability, > - Remove redundant break statements, I really like these changes and have nothing more to add: Reviewed-by: Wolfram Sang I also tested writing on R-Car V3U and V3M, so: Tested-by: Wolfram Sang Happy hacking, Wolfram --1HwUNj8StJmyV25U Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmJC18YACgkQFA3kzBSg KbZIQRAAkuzVjLW2JAhysnb/w5LhrCW28JB4+nAMveqOktOY8nICtFIKcYMBzKPz 8YPcWrsZw5vxhoO9U/QJLHGvqu1m2jcgVB5sQmHZK82PhBgHAWDH3bv01NCpau+C 6FQdyfi9UO1BJmsezDi/gBpLwSuQDGdWSdVZ8C6NCUUxjsZwqCmzahupWSCgzgHN ZqI821Tl3L5P7ynMtgZ0C66ATZ62tmtLlG/Iby21e6VeEnIvrdu15G1v9GeqFScY MQg89w38h15ZkU/nKOIuULw4ZwGqdKpFrTFG/GsUaiG8/qkRpqE99IMouIqO2svQ aGqGDT8JCx1NE92uB357nAkgjywo2q3cZqFEH2brG7GREVUfhzrP2d4eJqnYDWbB lrjiYPMgaMtDLjlW0RqcbETFQGQDVlVqHgU3dGBmSGzHm2R1hanTAuoxwyNUTtVv 3WxwDo91OP4RjS5QyY/6M2VE9nSyOSEY2XVB8pjw92OUoovU7CONwfIVgLm5FOcZ m0RBpwRWXgdU9P/+11OfvDJmVaREcMK/hi0OVvvi52Ynebq35JfHtsNUAkynCwM4 1/81dieewJoPzABVqtuqzbSIktbaXFGCT1+kmaj+aRn1ywhoWKldmMGIm8lXKuvm rZCYovg8BEKzTx2oQjxn25byetZGGRCIcbSWu1i3CEB65piiFFU= =USGZ -----END PGP SIGNATURE----- --1HwUNj8StJmyV25U--