From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9051AC433FE for ; Tue, 29 Mar 2022 11:14:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235630AbiC2LQe (ORCPT ); Tue, 29 Mar 2022 07:16:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235584AbiC2LQ3 (ORCPT ); Tue, 29 Mar 2022 07:16:29 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A491149F16; Tue, 29 Mar 2022 04:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648552486; x=1680088486; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=WW7g88rQ37IyUYcFgRuJ0tHqtRy6l/Sd1url/SgYtxc=; b=K+wygYLWZFOk+RJ11U9Z66aBwtbB1O1TCCLpz6oIBcqvN975juAj3U/m Ja3JYd2C2oilh/sRqJGuCVf0Wsi21+BUwxmeuFsqb3cbxRUI6ZckoA2td XDVSEu8lmLaUaKsBbuV02WgmgS+nXmCOVdi/zdx/q0f01oAnlmxFrYYtx ZEGSqTxsS2mp0mefMr23c8nMm8/MoNlUd5g6LMNmtemRhz1lXl3dU1l/j Kx6K6yGHPjeaoTrl2JOmV+nHZZSgeo7lLRV2iaqH5hUQ6ombPsd3EQRsb syvZRt6HxDdu4avxgM2ncQQp5u6jl6FdqnEvNG6kKCQA/tcQstIJ/JZoQ w==; X-IronPort-AV: E=McAfee;i="6200,9189,10300"; a="322408088" X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="322408088" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 04:14:46 -0700 X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="787559197" Received: from smile.fi.intel.com ([10.237.72.59]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 04:14:41 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nZ9nb-008hp9-9H; Tue, 29 Mar 2022 14:14:07 +0300 Date: Tue, 29 Mar 2022 14:14:07 +0300 From: Andy Shevchenko To: Fabien DESSENNE Cc: Gregory CLEMENT , Geert Uytterhoeven , Linus Walleij , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andrew Lunn , Sebastian Hesselbarth , Maxime Coquelin , Alexandre Torgue , Bartosz Golaszewski Subject: Re: [PATCH v1 2/5] pinctrl: stm32: Replace custom code by gpiochip_count() call Message-ID: References: <20220325200338.54270-1-andriy.shevchenko@linux.intel.com> <20220325200338.54270-2-andriy.shevchenko@linux.intel.com> <44057328-2454-4f4d-cc90-b0ca35ba1e5a@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44057328-2454-4f4d-cc90-b0ca35ba1e5a@foss.st.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 29, 2022 at 09:59:32AM +0200, Fabien DESSENNE wrote: > On 25/03/2022 21:03, Andy Shevchenko wrote: Thanks for review, my answers below. > > - for_each_available_child_of_node(np, child) > > Here we look for "available" child, while the new generic helper > gpiochip_count() looks for any child, available or not. > Would it be possible to hav gpiochip_count() looking for available child as > well? It's done already that way. The fwnode loop is done against available children. > It looks like there is '_available_' version of > 'device_for_each_child_node', maybe this shall be added too. No need. -- With Best Regards, Andy Shevchenko