From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50F1BC433F5 for ; Tue, 29 Mar 2022 17:08:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240055AbiC2RKW (ORCPT ); Tue, 29 Mar 2022 13:10:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240040AbiC2RKQ (ORCPT ); Tue, 29 Mar 2022 13:10:16 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E8F71C124 for ; Tue, 29 Mar 2022 10:08:30 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id EA1E432021E4; Tue, 29 Mar 2022 13:08:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 29 Mar 2022 13:08:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stwcx.xyz; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=jvPMxR9q+yWFejae5OI11dwt2wusc7Jmf7g8hc dfKlY=; b=N3RtwZA/78hsbte4IuBoXTnLNbf+QOckkvoLSr1gsIfjIirdujN1VJ UsuRxdIVdFsECcglQaHgQZEqixszZtHjuaj0rn0Q/MjGV+ZhZoa/fNQqJpxJyvxX ya8U30+KeMQ3YapBYvYddxPLQiQyEksSMaJT7RD1+L+LXDzYbaitXt0e8wjDXsPY rCr1CInZA9A2ZNd4Pkv/JvEcDFgfUIm5Cn4lovZ6z62/z4YCmUc2qgryPzeRUv0r TWqv1aoKQfx5qXcdhtnz4qlguOM6dgA7z0ODwPRSQXvmpIkEBaABnYXvfVfZAJ80 btqSBzio5W9ZSPftIw/K+gOheOqmU3qA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=jvPMxR9q+yWFejae5 OI11dwt2wusc7Jmf7g8hcdfKlY=; b=VwxiXgkNb80y5muigCIL6pmoxNVTH2dsy bELr1HO/+lNOQkqQ7p0GNF65Q9vxoHx5n2OsyUXVW4/vWcwy7meSPyaLW7vDLa1x CDDAPi7Q+10pPjyNrY8ng30/7IUsfQ8HVRZa2Uykg0m9Ipn3uOzZ5Q4Jv5WM9JgA F8d3azaZ2CYa8dNhyMSJGN/P7n+FssE/ErMr4kcIWnRdCU4N6RkfFvUb9zXVTU/0 7O5l/ucW7ZTPgELG1yiufo99rDPOaJzMyZAy62vfLRSKs1iSNWbXeI9ci7y/2QVp kptQj032dr8/D5smlmHSDYGaq0DqQJrJQaFbcB6fjAxYZB4aUxaVg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeitddgkeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfeehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomheprfgrthhrihgtkhcuhghilhhlihgrmhhsuceophgrthhrihgtkhessh htfigtgidrgiihiieqnecuggftrfgrthhtvghrnhepgeehheefffegkeevhedthffgudfh geefgfdthefhkedtleffveekgfeuffehtdeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepphgrthhrihgtkhesshhtfigtgidrgiihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 29 Mar 2022 13:08:25 -0400 (EDT) Date: Tue, 29 Mar 2022 12:08:24 -0500 From: Patrick Williams To: Greg Kroah-Hartman Cc: Geert Uytterhoeven , Jae Hyun Yoo , Iwona Winiarska , openbmc@lists.ozlabs.org, Pierre-Louis Bossart , linux-kernel@vger.kernel.org, Joel Stanley , Jason M Bills Subject: Re: [PATCH] peci: PECI should depend on ARCH_ASPEED Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="z4wolAb7mS9MAQex" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --z4wolAb7mS9MAQex Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 29, 2022 at 12:33:14PM +0200, Greg Kroah-Hartman wrote: > On Tue, Mar 29, 2022 at 11:21:37AM +0200, Geert Uytterhoeven wrote: > > The Platform Environment Control Interface (PECI) is only available on > > Baseboard Management Controllers (BMC) for Intel processors. Currently > > the only supported BMCs are ASpeed BMC SoCs. Hence add a dependency on > > ARCH_ASPEED, to prevent asking the user about the PECI subsystem when > > configuring a kernel without ASpeed SoC support. > >=20 > > Fixes: 6523d3b2ffa238ac ("peci: Add core infrastructure") > > Signed-off-by: Geert Uytterhoeven > > --- > > drivers/peci/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/drivers/peci/Kconfig b/drivers/peci/Kconfig > > index 89872ad833201510..0d3ef8ba0998d649 100644 > > --- a/drivers/peci/Kconfig > > +++ b/drivers/peci/Kconfig > > @@ -2,6 +2,7 @@ > > =20 > > menuconfig PECI > > tristate "PECI support" > > + depends on ARCH_ASPEED || COMPILE_TEST >=20 > I hate ARCH_ dependencies as there is nothing specific with that one > platform that means that this driver subsystem will only work on that > one. The motivation in the commit message isn't even accurate because the chips under ARCH_NPCM are usually used as a BMC as well and PECI is just as impor= tant for them. HPE also has a custom chip they use as BMC and they've started t= he process for upstreaming that support. > I'm all for fixing build dependancies, but it should be fine to build > all drivers for all arches. There are a few drivers, like PECI and FSI, that are likely only useful when being used in the BMC space. Is it worth having a "config BMC" for drivers which are likely only useful in a BMC environment and that we can "if BMC" around these drivers so they get hidden from the menuconfig for typical use cases? --=20 Patrick Williams --z4wolAb7mS9MAQex Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmJDPQgACgkQqwNHzC0A wRmUxQ/+PopAViu2crFxUxSdeLGnJt8czmB3zKxtmlaUU06S07tm0FcbGqljwTIK Nghx8aPmUjbnOIskWOPRM0BLyk0QrNM8OgGfY7+mTuMqhPTh/42XTJ+bKHnENtTP d5VxxLNrqUkEiLqO130YqgEAiRmlRsZOEIuxHeA9KQdPr9KkSyBez/3WK5FhVVHI 8kJT1Ht6aVNWWflRMrHqRMUyWvqDmCsegHnsDboU29+xlgKwMb4KgtmnzVeSqpyJ 5qJZZ24PbOYPLsOlFHHwcB9IaWrOeNNDyvOwoQBndRq3hsGEL7DMIwtHBUJWbgUm Z4Tpy7oanwY+uFDdLExhy+HhoxwyEStzW28q1xDPprZzhwjQRPMczRyQ3vXvpRq0 mib9w8xfYF0YFG28sTS394jpRtuVuZf40AJxHubMhjo+F8GNK4doO1GvGZMNnbRY KuR2xAUL5o+nNhiBxTKVDsG/uZa5ffqcVfOiqoWMW6wCeW1IV/usk0NUP1XCsaUh 3Zx2OujVymFsXfdyPyhPVQdiKstZ0FM9Ef8mqT4Xn73FxsJA0nyubeGj63uENTiG iOwn6YauefJybKd7LxBHSXSd+b5pBBcYDqph5IxE4qhdzOsmEg8yyJ0KWXtcIj7Y 4AkAPp8U9dWbrVxS6ItFjDQeJyNBHTTVmGQR85eYFnNeyGia5P0= =89Q3 -----END PGP SIGNATURE----- --z4wolAb7mS9MAQex--