Re: [PATCH] peci: PECI should depend on ARCH_ASPEED

Greg Kroah-Hartman
2022-03-29T10:33:23Z

On Tue, Mar 29, 2022 at 11:21:37AM +0200, Geert Uytterhoeven wrote:
> The Platform Environment Control Interface (PECI) is only available on
> Baseboard Management Controllers (BMC) for Intel processors. Currently
> the only supported BMCs are ASpeed BMC SoCs. Hence add a dependency on
> ARCH_ASPEED, to prevent asking the user about the PECI subsystem when
> configuring a kernel without ASpeed SoC support.
>
> Fixes: 6523d3b2ffa238ac ("peci: Add core infrastructure")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/peci/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/peci/Kconfig b/drivers/peci/Kconfig
> index 89872ad833201510..0d3ef8ba0998d649 100644
> --- a/drivers/peci/Kconfig
> +++ b/drivers/peci/Kconfig
> @@ -2,6 +2,7 @@
>
> menuconfig PECI
> tristate "PECI support"
> + depends on ARCH_ASPEED || COMPILE_TEST

I hate ARCH_ dependencies as there is nothing specific with that one
platform that means that this driver subsystem will only work on that
one.

I'm all for fixing build dependancies, but it should be fine to build
all drivers for all arches.

So sorry, I don't like this change.

greg k-h