From: Christoph Hellwig <hch@infradead.org>
To: Liu Shixin <liushixin2@huawei.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] fs: sysv: check sbi->s_firstdatazone in complete_read_super
Date: Wed, 30 Mar 2022 08:42:17 -0700 [thread overview]
Message-ID: <YkR6WdjLJyF0PMcd@infradead.org> (raw)
In-Reply-To: <20220330104215.530223-1-liushixin2@huawei.com>
On Wed, Mar 30, 2022 at 06:42:15PM +0800, Liu Shixin wrote:
> sbi->s_firstinodezone is initialized to 2 and sbi->s_firstdatazone is read
> from sbd. There's no guarantee that sbi->s_firstdatazone must bigger than
> sbi->s_firstinodezone. If sbi->s_firstdatazone less than 2, the filesystem
> can still be mounted unexpetly. At this point, sbi->s_ninodes flip to very
> large value and this filesystem is broken. We can observe this by
> executing 'df' command. When we execute, we will get an error message:
> "sysv_count_free_inodes: unable to read inode table"
This looks fine. Just curious: which variant of the sysv fs do you
use and what is the use case?
next prev parent reply other threads:[~2022-03-30 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 10:42 [PATCH -next] fs: sysv: check sbi->s_firstdatazone in complete_read_super Liu Shixin
2022-03-30 15:42 ` Christoph Hellwig [this message]
2022-03-31 3:49 ` Liu Shixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkR6WdjLJyF0PMcd@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liushixin2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox