From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB974C4332F for ; Wed, 30 Mar 2022 11:35:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343693AbiC3Lha (ORCPT ); Wed, 30 Mar 2022 07:37:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235330AbiC3Lh3 (ORCPT ); Wed, 30 Mar 2022 07:37:29 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95F7A1E3765; Wed, 30 Mar 2022 04:35:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648640144; x=1680176144; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=WvB6mJ9ryWwQ7CmVODZdOzNBEGHGFiTgCdDbkTsS7Js=; b=EK5Al7l7Is0w9/DsuO0AHaj2snZxjbegcrQo0Gb0Y+0Y82rRnFe2v9fO Lc7W3xk1rYt6IlpujbgfWrQDHoPHsqDLk3/BAuU89G4GGNCNQlRkTLDCg N6y7919zdcYKJ4AtA+Qwj+VJ8X7VbAZBQjdctza6yIxuXYcjAqWullst2 PFukbBUXkQ/EnW/lov6M1s+WgcOcxOG2JDudUUs5mZIFqqsc24fRq03Uh JfJChFbX/Sw9hZMoBecvYscLEOFJH0sEium/gr2lhtJll7mtPXV8LdrEX hI9Oq9cTWiJiCuDBBqokRsSGWngapDaz8JakFJ300f2WisKRbkNnylcEN A==; X-IronPort-AV: E=McAfee;i="6200,9189,10301"; a="247018452" X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="247018452" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2022 04:35:44 -0700 X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="519649292" Received: from smile.fi.intel.com ([10.237.72.59]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2022 04:35:35 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nZWbM-009N8T-Sw; Wed, 30 Mar 2022 14:35:00 +0300 Date: Wed, 30 Mar 2022 14:35:00 +0300 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Qianggui Song , Krzysztof Kozlowski , Fabien Dessenne , "open list:GPIO SUBSYSTEM" , Linux ARM , "open list:ARM/Amlogic Meson..." , Linux Kernel Mailing List , openbmc@lists.ozlabs.org, Linux-Renesas , linux-samsung-soc , linux-stm32@st-md-mailman.stormreply.com, Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Geert Uytterhoeven , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Bartosz Golaszewski , Philipp Zabel Subject: Re: [PATCH v2 02/13] gpiolib: Introduce gpiochip_node_count() helper Message-ID: References: <20220329152926.50958-1-andriy.shevchenko@linux.intel.com> <20220329152926.50958-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 30, 2022 at 12:02:07PM +0200, Geert Uytterhoeven wrote: > On Tue, Mar 29, 2022 at 5:29 PM Andy Shevchenko > wrote: ... > > + unsigned int count; > > Preinitialize to zero? Whatever for what consensus will be achieved. Initially I have that way, then I changed. > > + count = 0; > > + for_each_gpiochip_node(dev, child) > > + count++; > > Regardless: > Reviewed-by: Geert Uytterhoeven > Tested-by: Geert Uytterhoeven Thanks! -- With Best Regards, Andy Shevchenko