From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 024B6C433EF for ; Wed, 30 Mar 2022 12:30:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243385AbiC3McF (ORCPT ); Wed, 30 Mar 2022 08:32:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344509AbiC3Mbh (ORCPT ); Wed, 30 Mar 2022 08:31:37 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF9585B3D0; Wed, 30 Mar 2022 05:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648642639; x=1680178639; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=degjoFghFkob5qL3ehvoGOpozoU5J2XRIt2L6L1iub0=; b=Okt9Oqm+LDLdGXc/frHGOpysiYDcWjPX6TSDTb0sm+U+8pbb0EPbpKnH E84IkigOgB32vk6LO8/eoOeQYL8NYjmYdGoPGgzGQJQBMpmZ5ELJvVl5V rrFxOJwTn2nQL5uzglEgjFfrf0wp0Gx63hlIxlYHLPFCXiQTVBQf0vR+B 8rtKaC46TFy/T2RysdOnna/u0kslAKlXet9PmDUXmhyHhpT8mJapGXtj1 ASTGWiPe597Dc/uOFFt5pMDf5jcy0CH+0qh4raa/UgLBzPThojks7ZhgF sIt4OU1J8lD5w8ZHQcC+4cBiik/RlZyvQUnhbR3KT6O7iSDYwpOPORZvB A==; X-IronPort-AV: E=McAfee;i="6200,9189,10301"; a="345964900" X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="345964900" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2022 05:17:19 -0700 X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="565512740" Received: from smile.fi.intel.com ([10.237.72.59]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2022 05:17:10 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nZXFc-009OGn-0z; Wed, 30 Mar 2022 15:16:36 +0300 Date: Wed, 30 Mar 2022 15:16:35 +0300 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Qianggui Song , Krzysztof Kozlowski , Fabien Dessenne , "open list:GPIO SUBSYSTEM" , Linux ARM , "open list:ARM/Amlogic Meson..." , Linux Kernel Mailing List , openbmc@lists.ozlabs.org, Linux-Renesas , linux-samsung-soc , linux-stm32@st-md-mailman.stormreply.com, Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Geert Uytterhoeven , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Bartosz Golaszewski , Philipp Zabel Subject: Re: [PATCH v2 07/13] pinctrl: renesas: rza1: Switch to use for_each_gpiochip_node() helper Message-ID: References: <20220329152926.50958-1-andriy.shevchenko@linux.intel.com> <20220329152926.50958-8-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 30, 2022 at 12:00:27PM +0200, Geert Uytterhoeven wrote: > On Tue, Mar 29, 2022 at 5:29 PM Andy Shevchenko > wrote: ... > > + struct fwnode_reference_args of_args; > > fw_args? Perhaps just args as other drivers do? ... > > - chip->label = devm_kasprintf(rza1_pctl->dev, GFP_KERNEL, "%pOFn", > > - np); > > + chip->label = devm_kasprintf(rza1_pctl->dev, GFP_KERNEL, "%pfw", fwnode); > > This changes the label from e.g. "/soc/pinctrl@fcfe3000/gpio-11" to "gpio-11". Hmm... It seems other way around, i.e. it changes from the name to full name. > %pfwP? But conclusion here is correct. Good catch! ... > With the above fixed: > Reviewed-by: Geert Uytterhoeven > Tested-by: Geert Uytterhoeven > Acked-by: Geert Uytterhoeven Thanks for review and testing! -- With Best Regards, Andy Shevchenko