Re: [PATCH] ARM: module: Add all unwind tables when load module

Chen Zhongjin
2022-03-31T10:15:20Z

Hi Russell,

Thanks for comment! I've pushed v2 patch with your advises.

>>
>> - memset(maps, 0, sizeof(maps));
>> + INIT_LIST_HEAD(&table_list->mod_list);
>> + mod->arch.init_table = NULL;
>>
>> for (s = sechdrs; s < sechdrs_end; s++) {
>> - const char *secname = secstrs + s->sh_name;
>> + const unsigned int sectype = s->sh_type;
> Please loose this local variable.

Also I moved "txtname" inside func params.

+ const char *txtname = strcmp(".ARM.exidx", secname) == 0 ?
+ ".text" : secname + strlen(".ARM.exidx");
+ const Elf_Shdr *txt_sec = find_mod_section(hdr, sechdrs, txtname);

>>>

+ const Elf_Shdr *txt_sec = find_mod_section(hdr, sechdrs,
+ strcmp(".ARM.exidx", secname) ?
+ secname + strlen(".ARM.exidx") : ".text");