Re: [PATCH] ARM: module: Add all unwind tables when load module

Russell King (Oracle)
2022-03-31T10:35:47Z

On Thu, Mar 31, 2022 at 06:15:09PM +0800, Chen Zhongjin wrote:
> Hi Russell,
>
> Thanks for comment! I've pushed v2 patch with your advises.
>
> > > - memset(maps, 0, sizeof(maps));
> > > + INIT_LIST_HEAD(&table_list->mod_list);
> > > + mod->arch.init_table = NULL;
> > > for (s = sechdrs; s < sechdrs_end; s++) {
> > > - const char *secname = secstrs + s->sh_name;
> > > + const unsigned int sectype = s->sh_type;
> > Please loose this local variable.
>
> Also I moved "txtname" inside func params.
>
> + const char *txtname = strcmp(".ARM.exidx", secname) == 0 ?
> + ".text" : secname + strlen(".ARM.exidx");
> + const Elf_Shdr *txt_sec = find_mod_section(hdr, sechdrs, txtname);
>
> >>>
>
> + const Elf_Shdr *txt_sec = find_mod_section(hdr, sechdrs,
> + strcmp(".ARM.exidx", secname) ?
> + secname + strlen(".ARM.exidx") : ".text");
>

Hmm. I wonder whether it should be:

const Elf_Shdr *txt_sec;
const char *txtname;

if (!strcmp(".ARM.exidx", secname))
txtname = ".text";
else
txtname = secname + strlen(".ARM.exidx");

txt_sec = find_mod_section(hdr, sechdrs, txtname);

which looks cleaner to me.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!