Re: [PATCH v2 1/1] drm/amdkfd: Create file descriptor after client is added to smi_clients list

[Lee Jones <lee.jones@linaro.org>]

On Thu, 31 Mar 2022, Felix Kuehling wrote:

> 
> Am 2022-03-31 um 08:21 schrieb Lee Jones:
> > This ensures userspace cannot prematurely clean-up the client before
> > it is fully initialised which has been proven to cause issues in the
> > past.
> > 
> > Cc: Felix Kuehling <Felix.Kuehling@amd.com>
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Cc: "Christian König" <christian.koenig@amd.com>
> > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: amd-gfx@lists.freedesktop.org
> > Cc: dri-devel@lists.freedesktop.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> 
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> 
> I will apply to patch to amd-staging-drm-next.
> 
> > ---
> > 
> > CAVEAT: This patch is completely untested
> >          I can't seem to find a configuration strategy to compile test this
> >          allyesconfig and allmodconfig do not appear sufficient
> 
> That's very strange. It should get compiled if CONFIG_HSA_AMD is
> enabled.

Okay, I figured it out.

Apparently you can't give 'drivers/gpu/drm/amd' as a build param.

'drivers/gpu/drm' works as I expect however.

> I will at least compile-test it before I submit.

Great, thank you.

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog