Re: [PATCH 1/2] dt-bindings: dma: Add Apple ADMAC

Vinod Koul
2022-03-31T05:23:37Z

On 30-03-22, 18:44, Martin Povišer wrote:
> Apple's Audio DMA Controller (ADMAC) is used to fetch and store audio
> samples on Apple SoCs from the "Apple Silicon" family.
>
> Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
> ---
> .../devicetree/bindings/dma/apple,admac.yaml | 73 +++++++++++++++++++
> 1 file changed, 73 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/apple,admac.yaml
>
> diff --git a/Documentation/devicetree/bindings/dma/apple,admac.yaml b/Documentation/devicetree/bindings/dma/apple,admac.yaml
> new file mode 100644
> index 000000000000..34f76a9a2983
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/apple,admac.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dma/apple,admac.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Apple Audio DMA Controller (ADMAC)
> +
> +description: |
> + Apple's Audio DMA Controller (ADMAC) is used to fetch and store
> + audio samples on Apple SoCs from the "Apple Silicon" family.
> +
> +maintainers:
> + - Martin Povišer <povik+lin@cutebit.org>
> +
> +allOf:
> + - $ref: "dma-controller.yaml#"
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - apple,t6000-admac
> + - apple,t8103-admac
> + - const: apple,admac
> +
> + reg:
> + maxItems: 1
> +
> + '#dma-cells':
> + const: 1
> +
> + apple,internal-irq-destination:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Index influencing internal routing of the IRQs
> + within the peripheral.

do you have more details for this, is this for peripheral and if so
suited to be in dam-cells?

> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - '#dma-cells'
> + - dma-channels
> + - apple,internal-irq-destination
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/apple-aic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + dart_sio: iommu@235004000 {
> + compatible = "apple,t8103-dart", "apple,dart";
> + reg = <0x2 0x35004000 0x0 0x4000>;
> + interrupt-parent = <&aic>;
> + interrupts = <AIC_IRQ 635 IRQ_TYPE_LEVEL_HIGH>;
> + #iommu-cells = <1>;
> + };
> +
> + admac: dma-controller@238200000 {
> + compatible = "apple,t8103-admac", "apple,admac";
> + reg = <0x2 0x38200000 0x0 0x34000>;
> + dma-channels = <12>;
> + interrupt-parent = <&aic>;
> + interrupts = <AIC_IRQ 626 IRQ_TYPE_LEVEL_HIGH>;
> + #dma-cells = <1>;
> + iommus = <&dart_sio 2>;
> + apple,internal-irq-destination = <1>;
> + };
> --
> 2.33.0

--
~Vinod