From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org,
Gilad Ben-Yossef <gilad@benyossef.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: testmgr - test in-place en/decryption with two sglists
Date: Fri, 1 Apr 2022 09:30:13 +0100 [thread overview]
Message-ID: <Yka4Ff5eZuTP+NLy@silpixa00400314> (raw)
In-Reply-To: <20220326071159.56056-1-ebiggers@kernel.org>
On Sat, Mar 26, 2022 at 12:11:59AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> As was established in the thread
> https://lore.kernel.org/linux-crypto/20220223080400.139367-1-gilad@benyossef.com/T/#u,
> many crypto API users doing in-place en/decryption don't use the same
> scatterlist pointers for the source and destination, but rather use
> separate scatterlists that point to the same memory. This case isn't
> tested by the self-tests, resulting in bugs.
>
> This is the natural usage of the crypto API in some cases, so requiring
> API users to avoid this usage is not reasonable.
>
> Therefore, update the self-tests to start testing this case.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
FWIW, I tried this with QAT and I don't see any issue.
Regards,
--
Giovanni
next prev parent reply other threads:[~2022-04-01 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 7:11 [PATCH] crypto: testmgr - test in-place en/decryption with two sglists Eric Biggers
2022-03-27 6:04 ` Gilad Ben-Yossef
2022-04-04 23:34 ` Eric Biggers
2022-04-06 8:16 ` Gilad Ben-Yossef
2022-04-01 8:30 ` Giovanni Cabiddu [this message]
2022-04-08 8:31 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yka4Ff5eZuTP+NLy@silpixa00400314 \
--to=giovanni.cabiddu@intel.com \
--cc=ebiggers@kernel.org \
--cc=gilad@benyossef.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox