From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E927DC433EF for ; Fri, 1 Apr 2022 06:01:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245264AbiDAGD3 (ORCPT ); Fri, 1 Apr 2022 02:03:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233051AbiDAGD0 (ORCPT ); Fri, 1 Apr 2022 02:03:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38D5E25EC9C for ; Thu, 31 Mar 2022 23:01:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3B1F961B86 for ; Fri, 1 Apr 2022 06:01:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 425D8C2BBE4; Fri, 1 Apr 2022 06:01:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1648792896; bh=usiQ5/kmWskool16uoQNuX3zH9fqlkLk8OXUJrapyVs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hgDBvIU4HK7sNSbq7Es2681HocJZvVfc0diInnEolZ0o577aEhp56QPwNvlmJKHEO 0uXwiEaG1aIFcpFH/FnZM2z6CUYsNxMR8OirdyOoidTg/bIL3PA6wvUrobP+xQWci3 4vTuXwDt8myng+TKtmwZxbmwo0U8Rm/ffsOwCDqA= Date: Fri, 1 Apr 2022 08:01:34 +0200 From: Greg Kroah-Hartman To: "Fabio M. De Francesco" Cc: Dan Carpenter , sparmaintainer@unisys.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH v2] staging: unisys: Remove "struct dentry *eth_debugfs_dir" Message-ID: References: <20220331064751.29634-1-fmdefrancesco@gmail.com> <20220331082202.GZ12805@kadam> <5558288.DvuYhMxLoT@leap> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5558288.DvuYhMxLoT@leap> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 31, 2022 at 06:58:58PM +0200, Fabio M. De Francesco wrote: > On gioved? 31 marzo 2022 10:22:02 CEST Dan Carpenter wrote: > > On Thu, Mar 31, 2022 at 08:47:51AM +0200, Fabio M. De Francesco wrote: > > > There is no need for "struct dentry *eth_debugfs_dir" which is used for > > > debug / sysfs directories. Therefore, remove this "struct dentry" and > > > everything related (i.e., creation and removal). > > > > > > As a side effect of this change, the code has no more need of the > > > "cleanup_register_netdev" label, which can also be removed. > > > > > > Suggested-by: Dan Carpenter > > > Suggested-by: Greg Kroah-Hartman > > > Signed-off-by: Fabio M. De Francesco > > > --- > > > > > > v1 - v2: Add a couple of "Suggested-by" tags which were forgotten. > > > Thanks to Dan Carpenter and Greg Kroah-Hartman. > > > > > > > Thanks! > > > > Reviewed-by: Dan Carpenter > > > > regards, > > dan carpenter > > > I've just noticed that visornic and visorhba do other calls to > debugfs_create_dir() and debugfs_create_file() functions. > > I'm not sure whether or not this driver still needs those other calls. It looks like those drivers create actual files in debugfs with information in them, so I would leave them alone. thanks, greg k-h