From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 881B2C433EF for ; Fri, 1 Apr 2022 07:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343934AbiDAHsE (ORCPT ); Fri, 1 Apr 2022 03:48:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343926AbiDAHsA (ORCPT ); Fri, 1 Apr 2022 03:48:00 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 394551877C2 for ; Fri, 1 Apr 2022 00:46:11 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id u3so2973991wrg.3 for ; Fri, 01 Apr 2022 00:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=LCK4dl8vS+URWlqWXwwTuaXKgNuAXF8HAeyZxE1LFL8=; b=BpbnJzDgr4hcsVzm1oW1UkpOJL1mxsvWBqxwP9Pkn+dLZROp8D3MfzEya/xvto6CWr 5Hpy51yFe7FUyHZMj+ten4o6iHyYLGOYzGiFVa8ijakXUpvVAtHFLKterEGzz3KKQxlz ETKbdvSE/Hmbzm22TEyc/WygvjyFzFpHmwzsVIN4Dp/uQh1Q2uw9t6rGy1POR0K7WLPh tdLAt39eVc8KbF4Zm1vgyjPDgcyoVfk4wDMpQaiuzMPcSq4CvpRQr/y9jblbSlvajQzw wQoKcnKDtm3F84FSiVXrvhUmevYn2ZnpxpLRmKJS3rANa0ROOBR36YhB11AHzuGMrMep xe1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LCK4dl8vS+URWlqWXwwTuaXKgNuAXF8HAeyZxE1LFL8=; b=yKwjCkIhLiJ4jA+U2DLwmoD/dhsx5EcrMvhqmZ8fuucNrCZHHf001mHWhRlVI8k5DJ RZdFr87VXIYKXpJJN4DGDD+y1KXPNwjIkqlT/PshQ+Mg0etGyLaz2HYJFZr6DvEsTfUP OE/QSqBImbSRRfLijo+zYx0cgI1uNx3UBrfNYPdiW8rLm2eEJCOiQSVy0RaKg/yg/Pxe ycQ3ci4OYrf+i3xsPCUicgjSu5yLWzeyrVr84lNJpxIk+0JfVs6+AWSPucG4nvZMOKFK Lj+6GC+ZsrcInrg0XDb0TBHtXn5ssrcaUt4C5pPcUBEo8bIrI/Np0HWhXBmvw5k/Ltvd EcwA== X-Gm-Message-State: AOAM530hEvNRTm722btuaeFQQdnl8OwQUmQDrwRBl8C8a2smL6opHwOT 606+iYZRIO39HsnLfvsXlxv84hdKnARS5w== X-Google-Smtp-Source: ABdhPJx6WEFbSKf1cYZCJRp8RN1ZQmUurhpYge2WRdcRyKlEUox2QLvhk0FjNYGG4Dxt998JIXmRyQ== X-Received: by 2002:a5d:4e08:0:b0:205:89b6:1d4d with SMTP id p8-20020a5d4e08000000b0020589b61d4dmr6821818wrt.124.1648799169763; Fri, 01 Apr 2022 00:46:09 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id r4-20020a05600c35c400b0038cbd8c41e9sm9192704wmq.12.2022.04.01.00.46.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 00:46:08 -0700 (PDT) Date: Fri, 1 Apr 2022 08:46:06 +0100 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 0/2] mfd: twlx030: i2c remove callback cleanup Message-ID: References: <20220113101430.12869-1-u.kleine-koenig@pengutronix.de> <20220331131722.wt5uik3izzr7kewq@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220331131722.wt5uik3izzr7kewq@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 31 Mar 2022, Uwe Kleine-König wrote: > On Thu, Jan 13, 2022 at 11:14:28AM +0100, Uwe Kleine-König wrote: > > Hello, > > > > the remove paths of the twl4030 chip can fail and then returns an error > > code in twl_remove() early. This isn't a good thing, because the device > > will still go away with some resources not freed. > > For the twl6030 this cannot happen, and the first patch is just a small > > cleanup. For the twl4030 the situation is improved a bit: When the > > failure happens, the dummy slave devices are removed now. > > > > Note that twl4030_exit_irq() is incomplete. The irq isn't freed and > > maybe some more cleanup is missing which might boom if an irq triggers > > after the device is removed. Not sure that twl6030_exit_irq() is better > > in this regard. > > > > I noticed this issue because I work on making i2c_driver::remove return > > void as returning a value != 0 there is almost always an error attached > > to wrong expectations. > > It's one merge window ago now that I sent these two patches and didn't > get any feedback. Did this series fell through the cracks? Yes they did. Feel free to submit [RESEND]s any time after 2 weeks with no reply. They are now on my TODO list. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog