From: Andrew Lunn <andrew@lunn.ch>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, hkallweit1@gmail.com,
linux@armlinux.org.uk, Divya.Koppera@microchip.com,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
richardcochran@gmail.com, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net v2 0/3] net: phy: micrel: Remove latencies support lan8814
Date: Fri, 1 Apr 2022 14:57:46 +0200 [thread overview]
Message-ID: <Ykb2yoXHib6l9gkT@lunn.ch> (raw)
In-Reply-To: <20220401110522.3418258-1-horatiu.vultur@microchip.com>
On Fri, Apr 01, 2022 at 01:05:19PM +0200, Horatiu Vultur wrote:
> Remove the latencies support both from the PHY driver and from the DT.
> The IP already has some default latencies values which can be used to get
> decent results. It has the following values(defined in ns):
> rx-1000mbit: 429
> tx-1000mbit: 201
> rx-100mbit: 2346
> tx-100mbit: 705
So one alternative option here is that ptp4l looks at
/sys/class/net/<ifname>/phydev/phy_id
to identify the PHY, listens to netlink messages to determine the link
speed and then applies the correction itself in user space. That gives
you a pretty generic solution, works for any existing PHY and pretty
much any existing kernel version. And if you want board specific
values you can override them in the ptp4l configuration file.
Andrew
next prev parent reply other threads:[~2022-04-01 12:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 11:05 [PATCH net v2 0/3] net: phy: micrel: Remove latencies support lan8814 Horatiu Vultur
2022-04-01 11:05 ` [PATCH net v2 1/3] dt-bindings: net: micrel: Revert latency support and timestamping check Horatiu Vultur
2022-04-01 11:05 ` [PATCH net v2 2/3] net: phy: micrel: Remove latency from driver Horatiu Vultur
2022-04-01 11:05 ` [PATCH net v2 3/3] net: phy: micrel: Remove DT option lan8814,ignore-ts Horatiu Vultur
2022-04-01 12:57 ` Andrew Lunn [this message]
2022-04-01 14:11 ` [PATCH net v2 0/3] net: phy: micrel: Remove latencies support lan8814 Allan W. Nielsen
2022-04-01 14:39 ` Andrew Lunn
2022-04-02 13:43 ` Richard Cochran
2022-04-01 14:43 ` Russell King (Oracle)
2022-04-04 12:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykb2yoXHib6l9gkT@lunn.ch \
--to=andrew@lunn.ch \
--cc=Divya.Koppera@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox