From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wander Costa <wcosta@redhat.com>
Cc: "Wander Lairson Costa" <wander@redhat.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Johan Hovold" <johan@kernel.org>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
"Lukas Wunner" <lukas@wunner.de>, "Pali Rohár" <pali@kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Sergey Senozhatsky" <senozhatsky@chromium.org>,
"André Goddard Rosa" <andre.goddard@gmail.com>,
"Sudip Mukherjee" <sudipm.mukherjee@gmail.com>,
"David Laight" <David.Laight@aculab.com>,
"Jon Hunter" <jonathanh@nvidia.com>,
phil@raspberrypi.com
Subject: Re: [PATCH v6] serial/8250: Use fifo in 8250 console driver
Date: Mon, 4 Apr 2022 16:44:26 +0300 [thread overview]
Message-ID: <Ykr2OmXZyByrZ1uu@smile.fi.intel.com> (raw)
In-Reply-To: <CAAq0SUn4Z2y4-7fJcZ-T5rrnuwdJCt2+W-bGGmCxU6t+pA165A@mail.gmail.com>
On Mon, Apr 04, 2022 at 10:27:30AM -0300, Wander Costa wrote:
> On Mon, Apr 4, 2022 at 6:32 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, Apr 01, 2022 at 04:46:42PM -0300, Wander Lairson Costa wrote:
...
> > > + use_fifo = (up->capabilities & UART_CAP_FIFO) &&
> > > + /*
> > > + * BCM283x requires to check the fifo
> > > + * after each byte.
> > > + */
> > > + !(up->capabilities & UART_CAP_MINI) &&
> >
> > Perhaps you need to also comment why we are using tx_loadsz and not fifosize.
>
> Maybe it is better to document their difference in the struct
> declaration and not in a random usage.
Here, when one reads a code (as a non-familiar with the area), the use of
tx_loadsz confuses if one saw previously fifosize used somewhere. So, I agree
that it's good to document in the structure, but here it's also good to have
a comment to briefly hint the reader why this and not the other one is used.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-04-04 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 19:46 [PATCH v6 0/1] serial/8250: Use fifo in 8250 console driver Wander Lairson Costa
2022-04-01 19:46 ` [PATCH v6] " Wander Lairson Costa
2022-04-04 9:32 ` Andy Shevchenko
2022-04-04 13:27 ` Wander Costa
2022-04-04 13:44 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykr2OmXZyByrZ1uu@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=David.Laight@aculab.com \
--cc=andre.goddard@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=macro@orcam.me.uk \
--cc=pali@kernel.org \
--cc=phil@raspberrypi.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=wander@redhat.com \
--cc=wcosta@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox