From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
ChiYuan Huang <cy_huang@richtek.com>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
devicetree@vger.kernel.org
Subject: Re: [RFT PATCH 1/2] regulator: dt-bindings: richtek,rt4801: use existing ena_gpiod feature
Date: Mon, 4 Apr 2022 16:42:18 -0500 [thread overview]
Message-ID: <YktmOhXnZ0Amxcov@robh.at.kernel.org> (raw)
In-Reply-To: <20220401154237.1061331-2-krzysztof.kozlowski@linaro.org>
On Fri, 01 Apr 2022 17:42:36 +0200, Krzysztof Kozlowski wrote:
> The binding and driver duplicated regulator core feature of controlling
> regulators with GPIOs (of_parse_cb + ena_gpiod) and created its own
> enable-gpios property with multiple GPIOs.
>
> This is a less preferred way, because enable-gpios should enable only one
> element, not multiple. It also duplicates existing solution.
>
> Deprecate the original 'enable-gpios' and add per-regulator property.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../regulator/richtek,rt4801-regulator.yaml | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-04-04 22:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 15:42 [RFT PATCH 0/2] regulator: richtek,rt4801: use existing ena_gpiod feature Krzysztof Kozlowski
2022-04-01 15:42 ` [RFT PATCH 1/2] regulator: dt-bindings: " Krzysztof Kozlowski
2022-04-04 21:42 ` Rob Herring [this message]
2022-04-01 15:42 ` [RFT PATCH 2/2] regulator: " Krzysztof Kozlowski
[not found] ` <1648831895.12596.6.camel@richtek.com>
2022-04-01 20:36 ` [RFT PATCH 0/2] " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YktmOhXnZ0Amxcov@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox