From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47E72C433EF for ; Tue, 5 Apr 2022 05:43:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229928AbiDEFpY (ORCPT ); Tue, 5 Apr 2022 01:45:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229731AbiDEFpU (ORCPT ); Tue, 5 Apr 2022 01:45:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EE417F239; Mon, 4 Apr 2022 22:43:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9B54261138; Tue, 5 Apr 2022 05:43:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B612C340EE; Tue, 5 Apr 2022 05:43:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649137402; bh=sYFlsSIWnWY7H6pXl64UUXZKTyvh2XfqGMJOM5IlQgc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fcp+rxuW3kUhrT6QyWAoWbVm4gtx9v6BPIBnRjhjNOWlk+PBQBEZq7U+8GTSJmqi6 O1yMuk569h4MA00+xc8GC6bj8yJvWHlBNLNa17/FMWGwLaHe6eUDrxeFWtIbqbeoe2 /YFEdgjmtbULiQelaDiH+dN85wYw6G8xBoNi6tVJ8m0bBzMwR0FesakeprBPHK0V3P vE9NLKMEb3UveWniUIBkqPzY+dECo7GWpw8Br2Xrz1w6G+QP/GfCjZRuzxYi0bSu8E yw6AW1mc+F+rgEdKcAsllPObIToNnrzM6er3UxBbQk+F6K1hANQQoc7lNACvyFgKYG xe48pp/+sL5tw== Date: Tue, 5 Apr 2022 08:43:17 +0300 From: Leon Romanovsky To: Saeed Mahameed Cc: Jakub Kicinski , Paolo Abeni , Jason Gunthorpe , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, Saeed Mahameed , Tariq Toukan Subject: Re: [PATCH mlx5-next 4/5] net/mlx5: Remove tls vs. ktls separation as it is the same Message-ID: References: <67e596599edcffb0de43f26551208dfd34ac777e.1649073691.git.leonro@nvidia.com> <20220405003322.afko7uo527w5j3zu@sx1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220405003322.afko7uo527w5j3zu@sx1> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 04, 2022 at 05:33:22PM -0700, Saeed Mahameed wrote: > On 04 Apr 15:08, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > After removal FPGA TLS, we can remove tls->ktls indirection too, > > as it is the same thing. > > > > Reviewed-by: Tariq Toukan > > Signed-off-by: Leon Romanovsky > > --- > > .../net/ethernet/mellanox/mlx5/core/Makefile | 2 +- > > .../ethernet/mellanox/mlx5/core/en/params.c | 2 +- > > .../mellanox/mlx5/core/en_accel/en_accel.h | 11 +-- > > .../mellanox/mlx5/core/en_accel/ktls.c | 22 ++++- > > .../mellanox/mlx5/core/en_accel/ktls.h | 32 +++++++ > > .../mellanox/mlx5/core/en_accel/ktls_rx.c | 2 +- > > .../en_accel/{tls_stats.c => ktls_stats.c} | 38 ++++----- > > .../mellanox/mlx5/core/en_accel/ktls_tx.c | 18 +++- > > .../mellanox/mlx5/core/en_accel/ktls_txrx.h | 28 +++++- > > .../mellanox/mlx5/core/en_accel/tls.c | 70 --------------- > > .../mellanox/mlx5/core/en_accel/tls.h | 85 ------------------- > > .../mellanox/mlx5/core/en_accel/tls_rxtx.c | 70 --------------- > > .../mellanox/mlx5/core/en_accel/tls_rxtx.h | 85 ------------------- > > .../net/ethernet/mellanox/mlx5/core/en_main.c | 8 +- > > .../net/ethernet/mellanox/mlx5/core/en_rx.c | 5 +- > > .../ethernet/mellanox/mlx5/core/en_stats.c | 8 +- > > 16 files changed, 130 insertions(+), 356 deletions(-) > > rename drivers/net/ethernet/mellanox/mlx5/core/en_accel/{tls_stats.c => ktls_stats.c} (76%) > > Why not ktls_*.c => tls_*.c ? Mostly because other drivers use _ktls_ name for this type of functionality. Plus internally, Tariq suggested to squash everything into ktls. > > Since we now have one TLS implementation, it would've been easier to maybe > repurpose TLS to be KTLS only and avoid renaming every TLS to KTLS in all > functions and files. > > So just keep tls.c and all mlx5_tls_xyz functions and implement ktls > directly in them, the renaming will be done only on the ktls implementation > part of the code rather than in every caller. Should I do it or keep this patch as is? Thanks > > > delete mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c > > delete mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.h > > delete mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.c > > delete mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.h > > >